From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: CHENG Gao Newsgroups: gmane.emacs.devel Subject: Patch to lisp/bs.el Date: Sat, 20 Nov 2004 00:13:39 +0800 Message-ID: <6541lsuk.fsf@gmail.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1100880827 29928 80.91.229.6 (19 Nov 2004 16:13:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2004 16:13:47 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 19 17:13:38 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CVBOC-00075R-00 for ; Fri, 19 Nov 2004 17:13:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVBX6-0007YR-73 for ged-emacs-devel@m.gmane.org; Fri, 19 Nov 2004 11:22:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CVBWv-0007Y7-F3 for emacs-devel@gnu.org; Fri, 19 Nov 2004 11:22:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CVBWt-0007X5-6S for emacs-devel@gnu.org; Fri, 19 Nov 2004 11:22:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CVBWt-0007Wo-1v for emacs-devel@gnu.org; Fri, 19 Nov 2004 11:22:35 -0500 Original-Received: from [80.91.229.2] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CVBNk-0001rF-EE for emacs-devel@gnu.org; Fri, 19 Nov 2004 11:13:08 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CVBNj-0007hr-00 for ; Fri, 19 Nov 2004 17:13:07 +0100 Original-Received: from 218.2.142.128 ([218.2.142.128]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Nov 2004 17:13:07 +0100 Original-Received: from chenggao by 218.2.142.128 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 19 Nov 2004 17:13:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 32 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 218.2.142.128 User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (windows-nt) X-Payment: hashcash 1.2 1:20:041119:gmane.emacs.devel::mDz/HfMQiNW5h/Xa:000000000000000000000000000000000000000000004ZbL X-Hashcash: 1:20:041119:gmane.emacs.devel::mDz/HfMQiNW5h/Xa:000000000000000000000000000000000000000000004ZbL Cancel-Lock: sha1:UUCZeSXqFwND0lIkj/lDD3Z4efw= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30093 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30093 Reading Coding Conventions, I found it's not desirable to use next-line/previous-line. Searching Emacs files generate some files that dont follow this. Below is patch to lisp/bs.el with next-line/previous replaced with forward-line. --- bs.el.orig 2004-11-19 23:55:04.000000000 +0800 +++ bs.el 2004-11-19 23:56:08.000000000 +0800 @@ -1006,7 +1006,7 @@ "Move cursor vertically up one line. If on top of buffer list go to last line." (interactive "p") - (previous-line 1) + (forward-line -1) (if (<= (count-lines 1 (point)) (1- bs-header-lines-length)) (progn (goto-char (point-max)) @@ -1027,7 +1027,7 @@ (let ((last (line-end-position))) (if (eq last (point-max)) (goto-line (1+ bs-header-lines-length)) - (next-line 1)))) + (forward-line 1)))) (defun bs-visits-non-file (buffer) "Return t or nil whether BUFFER visits no file. -- 德不孤，必有邻 -- 《论语-里仁》