From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Line wrap reconsidered
Date: Sun, 19 Jul 2020 12:16:32 -0400 [thread overview]
Message-ID: <641EB401-D146-4EF0-AE92-994822C665AE@gmail.com> (raw)
In-Reply-To: <83sgdnh80n.fsf@gnu.org>
> On Jul 19, 2020, at 10:52 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 18 Jul 2020 13:14:15 -0400
>> Cc: Lars Ingebrigtsen <larsi@gnus.org>,
>> emacs-devel@gnu.org
>>
>>> A minor stylistic nit: I'd prefer the if - elseif clauses to yield the
>>> relevant character, and then apply CHAR_HAS_CATEGORY only once to that
>>> character at the end. (It is generally better to have only one return
>>> point from a function, especially when the function is short. If
>>> nothing else, it makes debugging easier.)
>>
>> I changed the it, do you code below this is ok?
>>
>> if (ch == 0)
>> return false;
>> else
>> return CHAR_HAS_CATEGORY(ch, cat);
>
> Yes. Or any of the variants shown by Stefan.
Cool.
>
>>>> if (it->line_wrap == WORD_WRAP && it->area == TEXT_AREA)
>>>> {
>>>> - if (IT_DISPLAYING_WHITESPACE (it))
>>>> - may_wrap = true;
>>>> - else if (may_wrap)
>>>> + /* Can we wrap here? */
>>>> + if (may_wrap && char_can_wrap_before (it))
>>>
>>> Likewise here.
>>
>>
>> In both can_wrap_before and can_wrap_after, I have a short circuit for the case when cjk_word_wrap is nil:
>>
>> if (!Vcjk_word_wrap)
>> return IT_DISPLAYING_WHITESPACE (it);
>>
>> That should guarantee the old behavior when cjk_word_wrap is nil, if that’s what you are asking about.
>
> I've seen that, but what bothers me is not this. It's the fact that
> the old code didn't test may_wrap, whereas the new code does.
>
I see. I changed the code a bit and added some explanation in the commit message. Hopefully that will convince you that the new logic is equivalent to the old one when cjk-word-wrap is nil.
>>>> + DEFVAR_BOOL("cjk-word-wrap", Vcjk_word_wrap,
>>>> + doc: /* Non-nil means wrap after CJK chracters.
>>>
>>> This is unclear. Does it mean after _any_ CJK character, or just
>>> after some? And if the latter, which ones?
>>
>> I added more detail and hopefully they are clearer now.
>
> Looks much better, thanks.
BTW, any ideas for alternatives for cjk-word-wrap? Maybe extended-word-wrap?
Yuan
next prev parent reply other threads:[~2020-07-19 16:16 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 18:13 Line wrap reconsidered Yuan Fu
2020-05-25 19:23 ` Eli Zaretskii
2020-05-25 19:31 ` Yuan Fu
2020-05-26 1:55 ` Ihor Radchenko
2020-05-26 12:55 ` Joost Kremers
2020-05-26 13:35 ` Yuan Fu
2020-05-26 14:47 ` Eli Zaretskii
2020-05-26 15:01 ` Ihor Radchenko
2020-05-26 15:29 ` Eli Zaretskii
2020-05-26 15:46 ` Ihor Radchenko
2020-05-26 16:29 ` Eli Zaretskii
2020-05-26 15:59 ` Stefan Monnier
2020-05-26 16:31 ` Eli Zaretskii
2020-05-26 16:43 ` Yuan Fu
2020-05-26 16:43 ` Ihor Radchenko
2020-05-26 18:57 ` Eli Zaretskii
2020-05-26 19:10 ` Yuan Fu
2020-05-26 19:59 ` Eli Zaretskii
2020-05-26 19:12 ` Ihor Radchenko
2020-05-26 20:04 ` Eli Zaretskii
2020-05-26 21:01 ` Stefan Monnier
2020-05-25 19:31 ` Stefan Monnier
2020-05-25 19:51 ` Yuan Fu
2020-05-25 20:43 ` Lars Ingebrigtsen
2020-05-25 23:26 ` Yuan Fu
2020-05-25 23:32 ` Yuan Fu
2020-05-26 2:15 ` Yuan Fu
2020-05-26 3:30 ` Yuan Fu
2020-05-26 4:46 ` Yuan Fu
2020-05-26 15:14 ` Eli Zaretskii
2020-05-26 15:00 ` Eli Zaretskii
2020-05-26 14:54 ` Eli Zaretskii
2020-05-26 17:34 ` Yuan Fu
2020-05-26 19:50 ` Eli Zaretskii
2020-05-26 20:31 ` Yuan Fu
2020-05-26 22:29 ` Yuan Fu
2020-05-27 17:29 ` Eli Zaretskii
2020-05-28 17:31 ` Yuan Fu
2020-05-28 18:05 ` Eli Zaretskii
2020-05-28 19:34 ` Yuan Fu
2020-05-28 20:42 ` Yuan Fu
2020-05-29 7:17 ` Eli Zaretskii
2020-05-29 6:56 ` Eli Zaretskii
2020-05-29 21:20 ` Yuan Fu
2020-05-30 6:14 ` Eli Zaretskii
2020-05-31 17:39 ` Yuan Fu
2020-05-31 17:55 ` Eli Zaretskii
2020-05-31 18:23 ` Yuan Fu
2020-05-31 18:47 ` Eli Zaretskii
2020-06-18 21:46 ` Yuan Fu
2020-06-19 6:17 ` Eli Zaretskii
2020-06-19 12:04 ` Yuan Fu
2020-06-19 12:38 ` Eli Zaretskii
2020-06-19 17:22 ` Yuan Fu
2020-06-19 17:47 ` Eli Zaretskii
2020-06-19 18:03 ` Yuan Fu
2020-06-19 18:34 ` Eli Zaretskii
2020-07-12 17:25 ` Yuan Fu
2020-07-12 18:27 ` Eli Zaretskii
2020-07-12 19:28 ` Yuan Fu
2020-07-13 19:46 ` Yuan Fu
2020-07-18 8:15 ` Eli Zaretskii
2020-07-18 17:14 ` Yuan Fu
2020-07-18 19:49 ` Yuan Fu
2020-07-18 20:25 ` Stefan Monnier
2020-07-19 14:52 ` Eli Zaretskii
2020-07-19 16:16 ` Yuan Fu [this message]
2020-07-19 16:17 ` Yuan Fu
2020-08-13 19:35 ` Yuan Fu
2020-08-14 5:55 ` Eli Zaretskii
2020-08-14 15:08 ` Yuan Fu
2020-08-15 9:10 ` Eli Zaretskii
2020-08-15 13:10 ` Fu Yuan
2020-08-15 14:56 ` Eli Zaretskii
2020-08-15 17:34 ` Yuan Fu
2020-08-15 17:46 ` Eli Zaretskii
2020-08-15 18:00 ` Yuan Fu
2020-08-15 18:47 ` Eli Zaretskii
2020-08-16 3:22 ` Yuan Fu
2020-08-16 14:15 ` Eli Zaretskii
2020-08-16 17:31 ` Yuan Fu
2020-08-22 7:42 ` Eli Zaretskii
2020-08-22 20:58 ` Yuan Fu
2020-08-23 7:12 ` Eli Zaretskii
2020-08-24 14:00 ` Yuan Fu
2020-05-27 15:20 ` Eli Zaretskii
2020-05-26 8:02 ` martin rudalics
2020-05-26 12:38 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641EB401-D146-4EF0-AE92-994822C665AE@gmail.com \
--to=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).