Re: [PATCH] memory-report: support calculating size for structures

["Yikai Zhao" <yikai@z1k.dev>]

On Mon, Aug 30, 2021, at 03:11, Lars Ingebrigtsen wrote:
> "Yikai Zhao" <yikai@z1k.dev> writes:
> 
> > Here's another patch on memory-report package which fixes the object
> > size calculation for structures (cl-defstruct types). Before this
> > patch, memory-report--object-size will report empty size for structure
> > objects, which results in incorrect report about "Largest Variables"
> > in memory-report result.
> 
> Thanks; looks good.
> 
> > Regarding the copyright assignment, I'm currently in the progress of
> > signing it. But maybe this patch is small enough to apply without it?
> 
> In itself, it would be small enough, but with the previous patch, it
> pushes it above the limit.  So after the assignment process is complete,
> can you remind us to apply the patch.  

I sent the signed document yesterday. I'm not sure if I should wait for the reply for the process to be complete.

> (And perhaps put the patch into
> the issue tracker with `M-x submit-emacs-patch' so that it's not
> forgotten.)

Aha, I didn't know that. I just sent a copy using `submit-emacs-patch'.

Thanks!

Yikai