Drop "experimental" status of --with-cairo ?

Drop "experimental" status of --with-cairo ?

[YAMAMOTO Mitsuharu]

I think the cairo drawing code on master is now stable enough and
consistent with non-cairo X11 build.  I suggest dropping
"experimental" status of the --with-cairo option.  WDYT?

			     YAMAMOTO Mitsuharu
			mituharu@math.s.chiba-u.ac.jp

Re: Drop "experimental" status of --with-cairo ?

[Stefan Monnier]

> I think the cairo drawing code on master is now stable enough and
> consistent with non-cairo X11 build.  I suggest dropping
> "experimental" status of the --with-cairo option.  WDYT?

Seeing all your coding efforts on it of late, I started to
compile --with-cairo last week and I didn't notice any negative
effect since then, so +1 from this user.


        Stefan

Re: Drop "experimental" status of --with-cairo ?

[Robert Pluim]

>>>>> On Tue, 18 Jun 2019 12:44:21 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:

    Mitsuharu> I think the cairo drawing code on master is now stable enough and
    Mitsuharu> consistent with non-cairo X11 build.  I suggest dropping
    Mitsuharu> "experimental" status of the --with-cairo option.  WDYT?

You mean setting --with-cairo to enabled by default? Sounds good to me
(but Iʼm by nature somewhat less than conservative with this kind of
stuff :-) )

Robert

Re: Drop "experimental" status of --with-cairo ?

[Eli Zaretskii]

> Date: Tue, 18 Jun 2019 12:44:21 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> 
> I think the cairo drawing code on master is now stable enough and
> consistent with non-cairo X11 build.  I suggest dropping
> "experimental" status of the --with-cairo option.  WDYT?

Are all the Cairo-related bugs in the debbugs database fixed?

Re: Drop "experimental" status of --with-cairo ?

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Tue, 18 Jun 2019 12:44:21 +0900
>> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>> 
>> I think the cairo drawing code on master is now stable enough and
>> consistent with non-cairo X11 build.  I suggest dropping
>> "experimental" status of the --with-cairo option.  WDYT?
>
> Are all the Cairo-related bugs in the debbugs database fixed?

A short search returns

--8<---------------cut here---------------start------------->8---
24144 normal,help	   [Michael Rose	   ] 25.1.50; cairo: window contents aren't resized when window is resized by creation/removal of windows in i3wm
23925 24310,normal,help	   [Roland Winkler	   ] 25.0.95; cairo: display broken when maximizing frames
21110 22442,normal,help	   [Robert Marshall	   ] cairo: Images viewed with Image[Imagemagick] mode are garbled
20997 minor,help	   [James Cloos		   ] display issues with cairo
--8<---------------cut here---------------end--------------->8---

There are also the following reports, but I'm not sure whether they are
really related to cairo

--8<---------------cut here---------------start------------->8---
34024 normal		   [Clément Pit-Claudel	   ] ImageMagick: Segfault when resizing SVG images
22503 normal		   [André Bjärby	   ] 25.0.90; maximizing frame doesn't redraw screen
14993 minor,patch	   [Xue Fuqiao		   ] [PATCH] Update information about fonts
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: Drop "experimental" status of --with-cairo ?

[Dmitry Gutov]

On 18.06.2019 22:44, Michael Albinus wrote:
> A short search returns
> 
> --8<---------------cut here---------------start------------->8---
> 24144 normal,help	   [Michael Rose	   ] 25.1.50; cairo: window contents aren't resized when window is resized by creation/removal of windows in i3wm
> 23925 24310,normal,help	   [Roland Winkler	   ] 25.0.95; cairo: display broken when maximizing frames
> 21110 22442,normal,help	   [Robert Marshall	   ] cairo: Images viewed with Image[Imagemagick] mode are garbled
> 20997 minor,help	   [James Cloos		   ] display issues with cairo

Looking at the age of the last comment in most of these, we might want 
to do another round of "are you still seeing this problem".

Re: Drop "experimental" status of --with-cairo ?

[YAMAMOTO Mitsuharu]

On Tue, 18 Jun 2019 21:47:54 +0900,
Robert Pluim wrote:
> 
> >>>>> On Tue, 18 Jun 2019 12:44:21 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:
> 
>     Mitsuharu> I think the cairo drawing code on master is now stable enough and
>     Mitsuharu> consistent with non-cairo X11 build.  I suggest dropping
>     Mitsuharu> "experimental" status of the --with-cairo option.  WDYT?
> 
> You mean setting --with-cairo to enabled by default? Sounds good to me
> (but Iʼm by nature somewhat less than conservative with this kind of
> stuff :-) )

That would be the next step.  For now, I suggest dropping the word
"(experimental)" from configure.ac, and encourage people (especially
those who previously tried --with-cairo but abandoned) to try it again
to iron out remaining issues.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Drop "experimental" status of --with-cairo ?

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

YAMAMOTO Mitsuharu wrote:
> I suggest dropping the word
> "(experimental)" from configure.ac, and encourage people (especially
> those who previously tried --with-cairo but abandoned) to try it again
> to iron out remaining issues.

The first part's easy enough; I installed the attached. Thanks for working on this.

[-- Attachment #2: 0001-with-cairo-is-no-longer-experimental.patch --]
[-- Type: text/x-patch, Size: 1843 bytes --]

From 50c5d5621cb5e6d7c86829ac4b776d81e47b2189 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 19 Jun 2019 00:06:39 -0700
Subject: [PATCH] --with-cairo is no longer experimental

Suggested by YAMAMOTO Mitsuharu in:
https://lists.gnu.org/r/emacs-devel/2019-06/msg00686.html
* configure.ac: Do not say --with-cairo is experimental.
* etc/NEWS: Say that --with-cairo is no longer experimental.
---
 configure.ac | 2 +-
 etc/NEWS     | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index a2e66c3f49..be5c4e35b1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -430,7 +430,7 @@ AC_DEFUN
 OPTION_DEFAULT_ON([rsvg],[don't compile with SVG image support])
 OPTION_DEFAULT_ON([lcms2],[don't compile with Little CMS support])
 OPTION_DEFAULT_ON([libsystemd],[don't compile with libsystemd support])
-OPTION_DEFAULT_OFF([cairo],[compile with Cairo drawing (experimental)])
+OPTION_DEFAULT_OFF([cairo],[compile with Cairo drawing])
 OPTION_DEFAULT_ON([xml2],[don't compile with XML parsing support])
 OPTION_DEFAULT_OFF([imagemagick],[compile with ImageMagick image support])
 OPTION_DEFAULT_ON([json], [don't compile with native JSON support])
diff --git a/etc/NEWS b/etc/NEWS
index 65dc095052..bf92a551a5 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -49,6 +49,10 @@ functions 'json-serialize', 'json-insert', 'json-parse-string', and
 'json-parse-buffer' are typically much faster than their Lisp
 counterparts from json.el.
 
+** The configure option --with-cairo is no longer experimental.
+This builds Emacs with Cairo drawing, and supports built-in printing
+when Emacs is built with GTK+.
+
 ** Emacs no longer defaults to using ImageMagick to display images,
 due to security and stability concerns.  To override the default, use
 'configure --with-imagemagick'.
-- 
2.17.1