From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Tue, 28 Nov 2023 18:32:55 +0200 Message-ID: <635a84ec-bda3-2fb3-6e04-39bb1245f3e0@gutov.dev> References: <87r0kw8nxu.fsf@catern.com> <3fe5a8cd-b355-d7eb-10ad-8846aef3387b@gutov.dev> <878r6mx1xc.fsf@betli.tmit.bme.hu> <90e4b9a7-3b51-587d-e317-b89e5d5464d9@gutov.dev> <87sf4scxax.fsf@betli.tmit.bme.hu> <77500777-aea2-14db-4aab-7a5dff43443b@gutov.dev> <00b85d5b-7878-4099-ab44-8200e153885d@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7081"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Felician Nemeth , Spencer Baugh , emacs-devel@gnu.org, Eshel Yaron , John Yates , Ergus , Filipp Gunbin To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 28 17:34:01 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8127-0001Ya-Cr for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Nov 2023 17:34:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r811N-0003Ja-2o; Tue, 28 Nov 2023 11:33:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r811H-0003Io-1m for emacs-devel@gnu.org; Tue, 28 Nov 2023 11:33:07 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r811E-0006XZ-8i for emacs-devel@gnu.org; Tue, 28 Nov 2023 11:33:05 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2CF0B3200A54; Tue, 28 Nov 2023 11:33:01 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 28 Nov 2023 11:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701189180; x=1701275580; bh=EsRMi/6mMai/XWFFiT06AeJZbQYYgnWo0Cl 5G99tuN4=; b=oBKm4GCzXggO1/BdMohDyXj5ER7UvNEBX+j+TuC4fSOWcUnPm6D MCJHgdmtVwkpIzetciHMKcGbH45r6hn2D7kAkGVnjrY0XA+xP94vSDM1bdxfy0W/ lcxBnzhrTwdqQr2bRpGmPbYl5ulSjWudZZmhZ3xveZSFCt5VR4U/EYlAsSq008ed iyxJ1Z3pofEIACGWqpCVm8Ov4t2pM4zqReN/EaljRX4gUc0LTsgELJKCtctvcwi5 Yjl72ygVED+fosEK2KlHjj6/WCOr8f/2PX/d2E3V2dMl8ZeQlXXKFsaTQMvnbebk FwfjYjtm23a81nV3qSwSKmgIqOMopz6jm1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701189180; x=1701275580; bh=EsRMi/6mMai/XWFFiT06AeJZbQYYgnWo0Cl 5G99tuN4=; b=WBsKBnoP0ramp+r5hI4b0c3PewnUYqJKsytGArq/9HtTamfr+x4 KzEet3pAGdTmqY8RL9c2eVltTKLWQz1ykFONeqbeFtNowC2OA7ZF/sZBTweP/iXX ZxEC7ERQaYSMKsfv5auXq8VQxcGUekJXIAAscsBwk2tiRqVy34yf5UzwFwM1FHFV MKAJK2bCZF5PKtXl94d6u2P2zO4EV/OrC8huFmKDccjLMRemW/gDbmyZrBAM4Ck3 sU1qY2DsMg1X6zNun2gQDiohVeLQ0Re9Xf2Rdu7QBhZYUEJh/SgCH0ckm4vOn/5U oEWgv9MRfGtP+bzoiJY/9F/3y9ODSVbF/8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 11:32:57 -0500 (EST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=64.147.123.24; envelope-from=dmitry@gutov.dev; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.37, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313328 Archived-At: On 28/11/2023 17:02, João Távora wrote: > On Tue, Nov 28, 2023 at 12:45 PM Dmitry Gutov wrote: > >> That's a good practice, and it works (and mitigates the issues) until we >> need to change the underlying function, for some reasons or other. In >> that sense, having the expansion use private functions (with "--" in the >> name) doesn't do much because those cannot be safely renamed, extended, >> etc. Unlike when they're called by a public function. > Sorry, that completely unspecified and vague scenario is irrelevant > in both theory and practice. Why would you need to rename them? > They're internal functions: noone else but you needs to know or care > about them. Being able to rename, or change arguments, or split into several, or severely rework, are all benefits of using internal functions, which are thus taken away. So essentially we have to choose stable public function(s) instead, no matter if they have "--" in the name. Which is what we need to do first. > This technique doesn't suffer from any other problem > a function interface wouldn't have as well. Can't tell why you're > trying to poke holes in such a well known and widely used Lisp > technique, but I must be off. Like you said, it's a tangent, so maybe split off a separate thread if you want to continue.