From: Bruno Haible <bruno@clisp.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: ChangeLog and commit messages
Date: Sun, 18 Jun 2023 16:03:35 +0200 [thread overview]
Message-ID: <6359963.hdfAi7Kttb@nimes> (raw)
Po Lu wrote:
> I find myself often frustrated that Git requires a commit title. In
> such a title, committers are expected to summarize in detail changes to
> dozens of different functions in less than 74 characters of text.
That's a feature, not a bug.
The commit title has benefits for the co-developers and for yourself, the
committer. Namely:
* If I am a co-developer, I want to know
- the purpose of the change,
- whether I can expect my existing tests or usage to continue working, or
whether it will break,
- whether I have the opportunity to extend my tests / change my usage.
For you, the committer, simply think of someone else asking you "what is
the point of this change?".
Thinking about this title for 30 seconds gives you the opportunity to
- detect when you are about to commit two unrelated things (e.g. a bug fix
and a new feature)
- if it's a new feature: question yourself whether you have been including
necessary documentation changes and/or a NEWS entry.
Bruno
next reply other threads:[~2023-06-18 14:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 14:03 Bruno Haible [this message]
[not found] <87a5wxb5sl.fsf.ref@yahoo.com>
2023-06-18 7:14 ` ChangeLog and commit messages Po Lu
2023-06-18 7:39 ` Eli Zaretskii
2023-06-18 7:41 ` Po Lu
2023-06-18 8:02 ` Eli Zaretskii
2023-06-18 14:50 ` Konstantin Kharlamov
2023-06-19 0:48 ` Po Lu
2023-06-19 6:25 ` Konstantin Kharlamov
2023-06-19 6:51 ` Po Lu
2023-06-19 9:07 ` Konstantin Kharlamov
2023-06-19 10:10 ` Po Lu
2023-06-19 11:57 ` Dmitry Gutov
2023-06-19 16:59 ` Eli Zaretskii
2023-06-19 17:24 ` Dmitry Gutov
2023-06-19 22:18 ` Konstantin Kharlamov
2023-06-19 16:33 ` Eli Zaretskii
2023-06-20 0:55 ` Po Lu
2023-06-23 6:50 ` Sean Whitton
2023-06-23 7:16 ` Eli Zaretskii
2024-08-27 4:23 ` Sean Whitton
2023-06-18 7:44 ` Sean Whitton
2023-06-18 22:38 ` Dmitry Gutov
2023-06-19 8:52 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6359963.hdfAi7Kttb@nimes \
--to=bruno@clisp.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).