1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
| | ;;;; testcover-unsafep.el -- Use testcover to test unsafep's code coverage
;; Copyright (C) 2002-2019 Free Software Foundation, Inc.
;; Author: Jonathan Yavner <jyavner@engineer.com>
;; Keywords: safety lisp utility
;; Package: testcover
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
(require 'testcover)
(defvar safe-functions)
;;;These forms are all considered safe
(defconst testcover-unsafep-safe
'(((lambda (x) (* x 2)) 14)
(apply 'cdr (mapcar (lambda (x) (car x)) y))
(cond ((= x 4) 5) (t 27))
(condition-case x (car y) (error (car x)))
(dolist (x y) (message "here: %s" x))
(dotimes (x 14 (* x 2)) (message "here: %d" x))
(let (x) (dolist (y '(1 2 3) (1+ y)) (push y x)))
(let (x) (apply (lambda (x) (* x 2)) 14))
(let ((x '(2))) (push 1 x) (pop x) (add-to-list 'x 2))
(let ((x 1) (y 2)) (setq x (+ x y)))
(let ((x 1)) (let ((y (+ x 3))) (* x y)))
(let* nil (current-time))
(let* ((x 1) (y (+ x 3))) (* x y))
(mapcar (lambda (x &optional y &rest z) (setq y (+ x 2)) (* y 3)) '(1 2 3))
(mapconcat #'(lambda (var) (propertize var 'face 'bold)) '("1" "2") ", ")
(setq buffer-display-count 14 mark-active t)
;;This is not safe if you insert it into a buffer!
(propertize "x" 'display '(height (progn (delete-file "x") 1))))
"List of forms that `unsafep' should decide are safe.")
;;;These forms are considered unsafe
(defconst testcover-unsafep-unsafe
'(( (add-to-list x y)
. (unquoted x))
( (add-to-list y x)
. (unquoted y))
( (add-to-list 'y x)
. (global-variable y))
( (not (delete-file "unsafep.el"))
. (function delete-file))
( (cond (t (aset local-abbrev-table 0 0)))
. (function aset))
( (cond (t (setq unsafep-vars "")))
. (risky-local-variable unsafep-vars))
( (condition-case format-alist 1)
. (risky-local-variable format-alist))
( (condition-case x 1 (error (setq format-alist "")))
. (risky-local-variable format-alist))
( (dolist (x (sort globalvar 'car)) (princ x))
. (function sort))
( (dotimes (x 14) (delete-file "x"))
. (function delete-file))
( (let ((post-command-hook "/tmp/")) 1)
. (risky-local-variable post-command-hook))
( (let ((x (delete-file "x"))) 2)
. (function delete-file))
( (let (x) (add-to-list 'x (delete-file "x")))
. (function delete-file))
( (let (x) (condition-case y (setq x 1 z 2)))
. (global-variable z))
( (let (x) (condition-case z 1 (error (delete-file "x"))))
. (function delete-file))
( (let (x) (mapc (lambda (x) (setcar x 1)) '((1 . 2) (3 . 4))))
. (function setcar))
( (let (y) (push (delete-file "x") y))
. (function delete-file))
( (let* ((x 1)) (setq y 14))
. (global-variable y))
( (mapc 'car (list '(1 . 2) (cons 3 4) (kill-buffer "unsafep.el")))
. (function kill-buffer))
( (mapcar x y)
. (unquoted x))
( (mapcar (lambda (x) (rename-file x "x")) '("unsafep.el"))
. (function rename-file))
( (mapconcat x1 x2 " ")
. (unquoted x1))
( (pop format-alist)
. (risky-local-variable format-alist))
( (push 1 format-alist)
. (risky-local-variable format-alist))
( (setq buffer-display-count (delete-file "x"))
. (function delete-file))
;;These are actually safe (they signal errors)
( (apply '(x) '(1 2 3))
. (function (x)))
( (let (((x))) 1)
. (variable (x)))
( (let (1) 2)
. (variable 1))
)
"A-list of (FORM . REASON)... that`unsafep' should decide are unsafe.")
(declare-function unsafep-function "unsafep" (fun))
;;;#########################################################################
(defun testcover-unsafep ()
"Executes all unsafep tests and displays the coverage results."
(interactive)
(testcover-unmark-all "unsafep.el")
(testcover-start "unsafep.el")
(let (save-functions)
(dolist (x testcover-unsafep-safe)
(if (unsafep x)
(error "%S should be safe" x)))
(dolist (x testcover-unsafep-unsafe)
(if (not (equal (unsafep (car x)) (cdr x)))
(error "%S should be unsafe: %s" (car x) (cdr x))))
(setq safe-functions t)
(if (or (unsafep '(delete-file "x"))
(unsafep-function 'delete-file))
(error "safe-functions=t should allow delete-file"))
(setq safe-functions '(setcar))
(if (unsafep '(setcar x 1))
(error "safe-functions=(setcar) should allow setcar"))
(if (not (unsafep '(setcdr x 1)))
(error "safe-functions=(setcar) should not allow setcdr")))
(testcover-mark-all "unsafep.el")
(testcover-end "unsafep.el")
(message "Done"))
;; testcover-unsafep.el ends here.
|