From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO. Date: Tue, 22 Sep 2020 22:32:28 +0300 Message-ID: <62c23861-62e0-2aab-7feb-70c03ea58fdf@yandex.ru> References: <20200921144653.9320.23809@vcs0.savannah.gnu.org> <20200921144656.3E99C206ED@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29225"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Stefan Kangas , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 22 21:33:23 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKo2V-0007VA-6m for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Sep 2020 21:33:23 +0200 Original-Received: from localhost ([::1]:51468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKo2U-0002AT-9G for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Sep 2020 15:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKo1k-0001fZ-RO for emacs-devel@gnu.org; Tue, 22 Sep 2020 15:32:36 -0400 Original-Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:34199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKo1j-0001ub-12 for emacs-devel@gnu.org; Tue, 22 Sep 2020 15:32:36 -0400 Original-Received: by mail-lj1-x232.google.com with SMTP id v23so15168136ljd.1 for ; Tue, 22 Sep 2020 12:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FDKNmT7O1fuuOEFaiYavrx7YP/Np/a4gPnOxU3ThU8w=; b=r6ohGEzJS5u9ickVHFT162UPV5Gop+aPL/caKOOmBzDJ5Oy1Nzlyarb/zCLElbykcf APB7pmZWX1QXTfYxcDtBuT0zxkne+FM0kdGCc17sNyTrvC6xmkq3tEoYiRx58vquL1ZE c7yvt/K7EHOBuQ5iwTMw0p4M3pDteKXMmk9Eld1zFpw1/gRJTS+P/y+HyjOeQfBuuDmR 8K3OgfERE2RQE/AkFqAnyI5Web3aqMfq0F1jL+FooUzr/10cmqRN829tWaHWx9BewA1O Qq75fO0HBqT6yezVaRp9MXzKrFJrCNqDvaS435W2SZUUypR7x9Mk/eOPAbOuqTg5Ae1I VJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FDKNmT7O1fuuOEFaiYavrx7YP/Np/a4gPnOxU3ThU8w=; b=rLO6UOV3YBgfANXC/gR6m/WN9Jt/D2chVBaxss1y21e+Y82/i8SxwBCEjFcUn3U8K4 hsCHanKXjeeONM7uV7U7Jr13v97GQdR+8rwZjNHXgNut96ixNWI94bKKI5SdlGjnfhZS wCn0OoCYyPVSBzOx1HWNY7Ca3/oajYue5gpGFgKfVT9n3uWltaUmJDNhiuqXmHj69Scs BuzzJqpZ1PI9Jlgd47Ww71fhbHGuaR+Q5ZX1xPmZbivaozYtq4B9U01OK5HqU0YwxXKc 4Mch63lkpjBzD/yBA8k/4mZCL7of9kvIjoYOgkBZdxexK/o54fod9Olnm/MBmIbNb6B7 9rDA== X-Gm-Message-State: AOAM531wB88vlLC7ND6xR/tokNPTK2V0rcZozmoech6dIHVhxPBWxkCz pCaHRUOJV7e+qeUYF/+I19KLo4aYREJqSA== X-Google-Smtp-Source: ABdhPJzdM6N3rjA6ETWtQfcA7f3FuPl1UfxH3Ed6IOaASGoaQTgB7IvShRbvW3dwEa02HwuKhon+pA== X-Received: by 2002:a2e:b531:: with SMTP id z17mr2237123ljm.30.1600803150143; Tue, 22 Sep 2020 12:32:30 -0700 (PDT) Original-Received: from [192.168.0.104] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id w26sm4123143ljm.30.2020.09.22.12.32.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 12:32:29 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=raaahh@gmail.com; helo=mail-lj1-x232.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256338 Archived-At: On 21.09.2020 21:23, Stefan Kangas wrote: > I was working under the assumption that these tests existed in their > current form only for historical reasons. So here I am, wreaking > general havoc. As was I, at a certain time in the past. >> I'm asking as a developer from started with the latter and then switched >> mostly to the former, due to the ease of debugging. >> >> The manual/indent tests also have an automated runner, which uses the >> 'diff' program. > > I think that the manual tests fail on at least two accounts: > > 1. There is no automated verification of success. They can even work semi-automatically, try: $ cd test/manual/indent $ make ruby.rb.test ../../../src/emacs --batch ruby.rb \ --eval '(indent-region (point-min) (point-max) nil)' \ --eval '(write-region (point-min) (point-max) "ruby.rb.new")' Indenting region... Indenting region...done diff -u -B ruby.rb ruby.rb.new Unfortunately, 'make all' doesn't work as expected there, only running that test for octave.m (which currently fails, to boot). > 2. They don't run with "make check". I think it can be made to run the above tests. Wish someone with more Makefile-related experience than myself, as well as free time, could look into it. > That said, please feel free to revert any commits you disagree with or > that gets in the way of your work. I think it goes without saying that > I don't want to make debugging harder for you or anyone else. I guess unless I do the above, I don't have a moral standing to revert them? Having an ERT test per each file in there might seem a tad redundant given the above option, but maybe there are good reasons why nobody has fixed the situations yet. As long as said manual test files are present, in one form or another, the debugging workflows can be retained. > But if there are limitations in debugging with ert, perhaps we should > work on improving its capabilities? It's capable enough in that regard (e.g. one can press 'd' and drop into the debugger, in the target buffer, exactly at the point of failure), yet still it requires more ceremony than the "manual" approach.