From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: RE: dropped 4th arg from all-completions
Date: Tue, 27 Apr 2010 13:27:09 -0700 [thread overview]
Message-ID: <6242E78507AA4134B71DFFF603C2B7C4@us.oracle.com> (raw)
In-Reply-To: <jwvsk6g4vn2.fsf-monnier+emacs@gnu.org>
> > I object to Emacs 23.2 dropping the 4th arg from `all-completions'.
>
> My 23.2 code shows all-completions accepts 4 args.
> Heck, even the 24 branch still accepts 4 args.
Your "acceptance" is hollow - bad faith. Emacs does not raise an error, but it
does not respect the arg. You have broken any code that uses a non-nil 4th arg.
And the doc shows only 3 args, and the byte compiler warns about #4.
> > I do not understand why the feature of ignoring candidates
> > that start with a space was removed.
>
> It doesn't have its place in `all-completions' (which is an internal
> function, and hence not directly related to any UI feature).
I disagree that it is an internal function.
> > FWIW, I use this 4th arg. I even have a user option and a
> > minibuffer toggle key that lets users control the removal
> > of such candidates. If you don't want to use the feature,
> > that's one thing, but why remove it from Emacs?
>
> You can get the same result by changing the completion table
> instead, or by changing the `predicate'. These approaches
> also have the advantage of being a lot more flexible.
My code works with multiple versions of Emacs. There is no reason that
`all-completions' cannot continue to support this argument. It has worked and
been used by Emacs users since Day One.
No proposal for the change. *No reason* given. No discussion.
When will you change the name from Emacs to Monnier?
next prev parent reply other threads:[~2010-04-27 20:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:01 dropped 4th arg from all-completions Drew Adams
2010-04-27 18:12 ` Stefan Monnier
2010-04-27 20:27 ` Drew Adams [this message]
2010-04-27 21:44 ` Chong Yidong
2010-04-27 22:02 ` Drew Adams
2010-04-28 4:09 ` Stefan Monnier
2010-04-28 4:29 ` Jay Belanger
2010-04-28 5:13 ` David Kastrup
2010-04-28 14:20 ` Stefan Monnier
2010-04-28 16:53 ` Jay Belanger
2010-04-28 6:53 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6242E78507AA4134B71DFFF603C2B7C4@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).