unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
To: Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, Jonas Bernoulli <jonas@bernoul.li>,
	Jim Porter <jporterbugs@gmail.com>
Subject: Re: Adding git-commit highlight mode?
Date: Fri, 03 Jan 2025 00:40:27 +0300	[thread overview]
Message-ID: <62392708bba07f66bdd63a62eb556ce884935d70.camel@yandex.ru> (raw)
In-Reply-To: <CADwFkmkzy4O7V-+p=1k6K5scBvUa4VfeZ0MkDet-o4rmFGU=AQ@mail.gmail.com>

On Thu, 2025-01-02 at 14:10 -0600, Stefan Kangas wrote:
> Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:
> 
> > On Thu, 2025-01-02 at 21:01 +0200, Eli Zaretskii wrote:
> > > > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > > > Date: Thu, 02 Jan 2025 21:30:53 +0300
> > > > 
> > > > Hi, just wanted to ask this before potentially taking on the
> > > > initiative
> > > > to only find the code will get rejected.
> > > > 
> > > > I think a ballpark estimate of 90% of Git usage among CVSes in
> > > > the
> > > > modern world is fair to assume.
> > > > 
> > > > But Emacs seems to be the only widely popular editor that still
> > > > doesn't
> > > > provide OOTB at least syntax highlight for git-commit format.
> > > > So,
> > > > does
> > > > anyone have opposition to adding a major mode that would be
> > > > bound
> > > > to
> > > > filenames like `COMMIT_EDITMSG` and others, and would provide
> > > > the
> > > > aforementioned highlight?
> 
> It would be great to have something like that in Emacs by default,
> indeed.  Even a simple mode with syntax highlighting would go a long
> way.
> 
> Note that there is some prior work here, see `git-commit-mode' in
> `magit`.  However, AFAIU, we recommend not looking at the
> implementation
> if you want to implement something like it, for reasons of copyright.
> The reason is that once you look at its implementation it's hard to
> write something original enough to be able to copyright assign the
> result to the Free Software Foundation, and even if it is original it
> can still (under some circumstances) be considered a derivative work
> of
> the code you have looked at.

Thank you! Yeah, I figured I shouldn't look at magit for license
reasons,  so I was going to use VSCode's syntax highlight as a
reference¹, since nowadays, at least from looking at other people, it
seems to be the most popular editor, so presumably its support should
be good.

However, for now I'm assuming Jim is taking over the initiative as he
has already written the mode.

1:
https://github.com/microsoft/vscode/tree/2bdb3e9b41bd72048ea2067a350d8536c82fc7f6/extensions/git-base



  parent reply	other threads:[~2025-01-02 21:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 18:30 Adding git-commit highlight mode? Konstantin Kharlamov
2025-01-02 19:01 ` Eli Zaretskii
2025-01-02 19:07   ` Konstantin Kharlamov
2025-01-02 20:10     ` Stefan Kangas
2025-01-02 21:01       ` Eli Zaretskii
2025-01-02 21:38         ` Stefan Kangas
2025-01-03  5:26           ` Jim Porter
2025-01-02 21:40       ` Konstantin Kharlamov [this message]
2025-01-03  5:29         ` Jim Porter
2025-01-03 13:08       ` Jonas Bernoulli
2025-01-02 20:11     ` Eli Zaretskii
2025-01-02 21:19       ` Arsen Arsenović
2025-01-02 21:53         ` Stefan Kangas
2025-01-02 22:27           ` Arsen Arsenović
2025-01-03 21:02           ` Sean Whitton
2025-01-04  7:17             ` Eli Zaretskii
2025-01-04  9:52               ` Sean Whitton
2025-01-03  6:45         ` Eli Zaretskii
2025-01-02 19:17 ` Jim Porter
2025-01-02 19:19   ` Konstantin Kharlamov
2025-01-02 20:17   ` Eli Zaretskii
2025-01-03 21:14   ` Björn Bidar
2025-01-05 14:39     ` Philip Kaludercic
2025-01-05 22:48       ` Konstantin Kharlamov
     [not found]   ` <87r05jbnw2.fsf@>
2025-01-03 22:52     ` Konstantin Kharlamov
2025-01-04  1:22       ` Björn Bidar
     [not found]       ` <87v7uv9xub.fsf@>
2025-01-04  1:45         ` Konstantin Kharlamov
2025-01-05  0:46           ` Björn Bidar
     [not found]           ` <871pxiulxz.fsf@>
2025-01-05  3:55             ` Konstantin Kharlamov
2025-01-04 12:50         ` Jonas Bernoulli
2025-01-04 17:20           ` Jonas Bernoulli
2025-01-05  0:32           ` Björn Bidar
2025-01-05 18:47           ` Jim Porter
2025-01-05  0:42 ` Björn Bidar
     [not found] ` <875xmuum48.fsf@>
2025-01-05  3:49   ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62392708bba07f66bdd63a62eb556ce884935d70.camel@yandex.ru \
    --to=hi-angel@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jonas@bernoul.li \
    --cc=jporterbugs@gmail.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).