From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>,
Thierry Volpiatto <thievol@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command'
Date: Sat, 6 Jul 2024 12:47:30 -0700 [thread overview]
Message-ID: <61d599b4-2235-091c-6623-a090d48e93d9@gmail.com> (raw)
In-Reply-To: <CADwFkmk3UcQ2oL107=Ne3Dqv0-7i+s8yCbMyXnLaxf43RExRCg@mail.gmail.com>
On 7/6/2024 10:15 AM, Stefan Kangas wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
>
>> branch: master
>> commit 7f631a3e2aca97e95b8659c902c25ab21f084e08
>> Author: Thierry Volpiatto <thievol@posteo.net>
>> Commit: Jim Porter <jporterbugs@gmail.com>
>>
>> Allow using multiple buffers in 'eshell-command'
[snip]
> This new test is failing here:
Hm, I can't reproduce that, but I'm guessing it's a race condition with
the process sentinel. Does this make the test pass for you?
----------------------------------------
diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el
index 568f6745067..6c79f753d6f 100644
--- a/lisp/eshell/eshell.el
+++ b/lisp/eshell/eshell.el
@@ -357,8 +357,8 @@ eshell-command
(with-current-buffer bufname
;; Stop all the processes in the old buffer (there may
;; be several).
- (eshell-process-interact #'interrupt-process t))
- (accept-process-output)
+ (eshell-process-interact #'interrupt-process t)
+ (eshell-wait-for-process (mapcar #'car
eshell-process-list)))
(kill-buffer bufname))
((eq eshell-command-async-buffer 'confirm-new-buffer)
(shell-command--same-buffer-confirm "Use a new buffer")
next prev parent reply other threads:[~2024-07-06 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172023408734.9826.6615246233994903888@vcs2.savannah.gnu.org>
[not found] ` <20240706024807.B74E4C1FB6A@vcs2.savannah.gnu.org>
2024-07-06 17:15 ` master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command' Stefan Kangas
2024-07-06 19:47 ` Jim Porter [this message]
2024-07-06 21:17 ` Jim Porter
2024-07-10 0:32 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d599b4-2235-091c-6623-a090d48e93d9@gmail.com \
--to=jporterbugs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).