From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: calc.el Date: Mon, 17 Jun 2019 13:03:27 +0200 Message-ID: <61836594-E548-41BF-B367-D30768860ED0@acm.org> References: <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> <83v9x6vpap.fsf@gnu.org> <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49297"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 17 13:05:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcpSS-000Cek-8C for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 13:05:52 +0200 Original-Received: from localhost ([::1]:46084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcpSR-000576-6b for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 07:05:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47867) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcpQS-00056K-8J for emacs-devel@gnu.org; Mon, 17 Jun 2019 07:03:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcpQP-0003Ru-Ke for emacs-devel@gnu.org; Mon, 17 Jun 2019 07:03:48 -0400 Original-Received: from mail84c50.megamailservers.eu ([91.136.10.94]:35918 helo=mail18c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcpQN-00036F-J3 for emacs-devel@gnu.org; Mon, 17 Jun 2019 07:03:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1560769409; bh=uOAzcHRUJVRC70zjaFyhUTg8gFy9Gstygz0jwUcB5/o=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=NagPY9sy7rFVDpLBofKrKIFEGdkKZvR5qsBAv0TRC1Z80MnV6L3/psxl+6aEDcfpK roRnjmtiBSBU8TShOl6oXzYtCK8DsvbuhiSOz5X3hVYFwpQ+Hw9Ofjz3r1EzqpdrhS Bg6MtPP79MjuRl4bkwZBCzYmkos0PTTcLSxm1dOg= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x5HB3Rs3005421; Mon, 17 Jun 2019 11:03:29 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0206.5D077381.004B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=c7eFvy1l c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=OocQHUDgAAAA:8 a=Rhjd925crAUynWKBVrIA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.94 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237777 Archived-At: 17 juni 2019 kl. 12.47 skrev Lars Ingebrigtsen : >=20 >> make[1]: Entering directory '/home/larsi/src/emacs/trunk/lisp' >> ELC calc/calc.elc >> ELC calc/calc-macs.elc >> make[1]: Leaving directory '/home/larsi/src/emacs/trunk/lisp' >>=20 >> Well, that was easy? :-) >>=20 >> calc-tests passes, too... >=20 > I had a look at the file, and making that file lexical seems > straight-forward. That is, no changes were needed, and the tests pass > (but I haven't checked whether there's really any coverage), but M-x > calc works afterwards, so I went ahead and added the -*- lexical. The coverage of calc-tests is practically infinitesimal, but = calc-macs.el is probably safe with lexical-binding.