From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Some issues with the tree-sitter branch
Date: Mon, 17 Oct 2022 02:12:13 -0700 [thread overview]
Message-ID: <6164C2B0-B0D0-4AEB-B76C-7588D643DBBB@gmail.com> (raw)
In-Reply-To: <83y1tf2be6.fsf@gnu.org>
>
>> I added buffer size check at parser creation time, and used casts to uint32_t liberally, assuming the values never overflows and, so we don’t need to handle the error at a million places. But I should have added checks in ts_after_chang and other places where buffer size could change. I’ll add checks in ts_after_change and other places, and if the argumetns overflows uint32, it will set a flag (say, buffer_too_large) in the parser object, and next time any lisp function tries to use that parser, an buffer-too-large error will be signaled. WDYT?
>
> That sounds fine to me, but I think we also should do something when
> some value that can be larger than UINT_MAX is passed to tree-sitter
> functions, because doing so might cause tree-sitter do something for a
> completely unrelated portion of the buffer. At the very least add
> eassert there, so that at least a build with --enable-checking will
> detect such cases.
IIUC you don’t want to hide and delay the error, right? That makes sense. I can add assertions, those assertions shouldn’t interfere with normal usage.
Yuan
next prev parent reply other threads:[~2022-10-17 9:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 13:32 Some issues with the tree-sitter branch Eli Zaretskii
2022-10-16 14:01 ` Eli Zaretskii
2022-10-16 15:10 ` Eli Zaretskii
2022-10-16 19:36 ` tree-sitter: Paths used for loading of language definitions Jostein Kjønigsen
2022-10-16 20:12 ` Daniel Martín
2022-10-17 4:27 ` Yuan Fu
2022-10-17 7:14 ` Jostein Kjønigsen
2022-10-17 7:29 ` Yuan Fu
2022-10-17 8:02 ` Eli Zaretskii
2022-10-17 9:02 ` Yuan Fu
2022-10-17 9:08 ` Eli Zaretskii
2022-10-17 11:56 ` Stephen Leake
2022-10-17 13:39 ` Eli Zaretskii
2022-10-17 21:15 ` Yuan Fu
2022-10-17 4:53 ` Some issues with the tree-sitter branch Yuan Fu
2022-10-17 5:37 ` Po Lu
2022-10-17 5:48 ` Yuan Fu
2022-10-17 6:48 ` Eli Zaretskii
2022-10-17 9:12 ` Yuan Fu [this message]
2022-10-17 10:14 ` Eli Zaretskii
2022-10-18 0:15 ` Yuan Fu
2022-10-18 0:14 ` Yuan Fu
2022-10-18 16:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6164C2B0-B0D0-4AEB-B76C-7588D643DBBB@gmail.com \
--to=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).