Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string

Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string

[Dmitry Gutov]

On 04/27/2016 08:19 AM, Leo Liu wrote:
> branch: emacs-25
> commit e55d0db95700edd11e71660729566c67b6c563b3
> Author: Leo Liu <sdl.web@gmail.com>
> Commit: Leo Liu <sdl.web@gmail.com>
>
>     Fix revision calculation in vc-git-mode-line-string
>
>     * lisp/vc/vc-git.el (vc-git-mode-line-string): Use
>       vc-git-working-revision because vc-working-revision needs to decide
>       the backend and may return nil.

Why was that bad?

vc-working-revision also caches the result, and vc-git-working-revision 
does not. Do you want Emacs to call Git multiple times per second?

Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string

[Leo Liu]

On 2016-04-27 12:40 +0300, Dmitry Gutov wrote:
> Why was that bad?
>
> vc-working-revision also caches the result, and
> vc-git-working-revision does not. Do you want Emacs to call Git
> multiple times per second?

Thanks, I hadn't paid attention to the cache issue. I pushed a different
fix that doesn't bypass the cache.

We need to avoid deciding the backend at that point and
vc-git-mode-line-string expects REV to be non-nil or the substring form
will complain.

Leo

Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string

[Dmitry Gutov]

On 04/27/2016 05:23 PM, Leo Liu wrote:

> We need to avoid deciding the backend at that point and
> vc-git-mode-line-string expects REV to be non-nil or the substring form
> will complain.

..........
..........
..........

Oh, you mean when the HEAD is in detached mode? I see.

The current version looks fine, thanks.