From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string Date: Wed, 27 Apr 2016 12:40:46 +0300 Message-ID: <60a6de33-1bc9-b5e4-82b9-c1a26d655a94@yandex.ru> References: <20160427051934.30651.96563@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1461750059 29818 80.91.229.3 (27 Apr 2016 09:40:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Apr 2016 09:40:59 +0000 (UTC) To: emacs-devel@gnu.org, Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 27 11:40:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avLxp-0003Ec-GE for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 11:40:57 +0200 Original-Received: from localhost ([::1]:42018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avLxo-00049z-PY for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 05:40:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avLxk-000462-NK for emacs-devel@gnu.org; Wed, 27 Apr 2016 05:40:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avLxg-0004IU-My for emacs-devel@gnu.org; Wed, 27 Apr 2016 05:40:52 -0400 Original-Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:36482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avLxg-0004IP-H0 for emacs-devel@gnu.org; Wed, 27 Apr 2016 05:40:48 -0400 Original-Received: by mail-wm0-x244.google.com with SMTP id w143so11085876wmw.3 for ; Wed, 27 Apr 2016 02:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=moY2vTcdvd97SVAk2n1ZhK5N8C9QkGQsjDGsbXRsqEk=; b=OQBZPkZNE5lMgRC9dLrTOtN/oKtpHrBO3Djr6W538mAlosf1MErTqn+2EH2tC3Ja5K dyBoIKmURUMyMSrZW51pFH2xAf0mn+ymgQ/GSceeSscO9doMyKuc6ttnPyHdHbv5PHYw KOd5tj9pm4w9Hn5DWCfRj2wGMPw9dxbOgmu+LJuahX+5iB4iyp48c4NRgPS3NypCyHz+ eU2/hqQKbbmVbOmk+ZwjAka7Bgg4C3PwxxHnAk4eGrYjrI6DnoKudaWzKKmNUU8zfu3x WWAS7eWaxO3orpTBKPVf6f1UBRKhC0Arelj5x9HlPKfGfENCZnXQU/eyKAQCXi5bdSoA ToOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=moY2vTcdvd97SVAk2n1ZhK5N8C9QkGQsjDGsbXRsqEk=; b=OmSOoH4bj+T7RUpMuNH2wkybUzgp5EDiDGrwh5mur3RJkmWAYqhxC8DeDwoYiqFzkg IkCIau0lfAacP3yZG+sCDXeiXRKJ6xCvFHJYMfnbmQmnLToG+0f7eVyFjyTI9r2VDRWb ZxNH/30aucYyOaCLwqmknyVzkFPF37tjCOWgMlms84XU7mW6h/yVjm3WDlqM4zegHMLP OoLJi9ASGHkWCSzdjx0KnpODaZz2JmGRYEe0mpAOKPtPCBNFYyABwrTdvvOkITjSBoxR aCN1lEbbaiqKtboV47eMbu9zxrLpE1MFyVUlMmtaQzRc48FxpdbAjfQU/MN/2Wgkg1U7 cKkw== X-Gm-Message-State: AOPr4FVqKzQJrVDUStbJVCQBpYC71lSFNM1Do321qzIJZxp8kpaOU5j0NJPbfwOQgJST3Q== X-Received: by 10.194.142.240 with SMTP id rz16mr7867701wjb.126.1461750047870; Wed, 27 Apr 2016 02:40:47 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id a200sm21645419wme.8.2016.04.27.02.40.46 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Apr 2016 02:40:47 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203382 Archived-At: On 04/27/2016 08:19 AM, Leo Liu wrote: > branch: emacs-25 > commit e55d0db95700edd11e71660729566c67b6c563b3 > Author: Leo Liu > Commit: Leo Liu > > Fix revision calculation in vc-git-mode-line-string > > * lisp/vc/vc-git.el (vc-git-mode-line-string): Use > vc-git-working-revision because vc-working-revision needs to decide > the backend and may return nil. Why was that bad? vc-working-revision also caches the result, and vc-git-working-revision does not. Do you want Emacs to call Git multiple times per second?