From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: master 3d609375f99: Track nil colors in term Date: Thu, 03 Oct 2024 20:22:51 -0700 Message-ID: <609293D2-CAD6-4085-B231-921C3F449773@dancol.org> References: <172793041800.756080.13048066383280198150@vcs3.savannah.gnu.org> <20241003044018.B2B201687C1@vcs3.savannah.gnu.org> <874j5t8wzp.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: K-9 Mail for Android To: Michael Albinus , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 04 05:23:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swYuv-0000P7-U5 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Oct 2024 05:23:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swYuC-00040k-A9; Thu, 03 Oct 2024 23:23:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swYuA-00040Q-1k for emacs-devel@gnu.org; Thu, 03 Oct 2024 23:22:58 -0400 Original-Received: from dancol.org ([2600:3c01:e000:3d8::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swYu7-0000AV-M8 for emacs-devel@gnu.org; Thu, 03 Oct 2024 23:22:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: References:In-Reply-To:Subject:To:From:Date:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GmjysdQEbbFlHS02BwNCls4pQvcASQ7tZOXlmPK4UUY=; b=eh8AzNY3NB8SllZ4ht7dziKFZH PZZ+bT0in5aCCRV6S50un3p1XIjQ3BZFr5lbACz8YybhmPoQDrDt+P6W220KfeDLl4umTc9I9DGAR ySD3Ggxz7/xMGu/swV7ijPrdEdx+c3pZFGRJYIpMuhO0kq7RffaAtlDC4odQBT3FFJ4WtjcQSVQhP By6OShOBGJcvSw7wlTA36YHpzWh1AKtRg4SKg3l8GjBym0aUiBsLHYpjfgr4dD717GbrQZ0Vk457z o8FEYvl6h35C3gNOEgpd2DXBqHnBKIEWcDJZBr8sF/Xs2B6sPs9VOP13Hc9oAoBJIPc7UiESPADHk K3ZN7u6Q==; Original-Received: from [12.51.135.7] (port=39638 helo=[127.0.0.1]) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1swYu3-0001Un-2T; Thu, 03 Oct 2024 23:22:52 -0400 In-Reply-To: <874j5t8wzp.fsf@gmx.de> Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@dancol.org; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324297 Archived-At: On October 3, 2024 12:30:02 AM PDT, Michael Albinus wrote: >Daniel Colascione writes: > >Hi Daniel, > >> branch: master >> commit 3d609375f99cd0d4b7a441802d4616bad385e31d >> Author: Daniel Colascione >> Commit: Daniel Colascione >> >> Track nil colors in term > >This breaks term-tests=2Eel > >--8<---------------cut here---------------start------------->8--- ># make -C test term-tests >Test term-colors backtrace: > signal(ert-test-failed (((should (equal (text-properties-at 0 result > ert-fail(((should (equal (text-properties-at 0 result) (text-propert > (if (unwind-protect (setq value-52 (apply fn-50 args-51)) (setq form > (let (form-description-54) (if (unwind-protect (setq value-52 (apply > (let ((value-52 'ert-form-evaluation-aborted-53)) (let (form-descrip > (let* ((fn-50 #'equal) (args-51 (condition-case err (list (text-prop > (let ((result (term-test-screen-from-input 40 12 str))) (let* ((fn-4 > (let ((str x41) (expected x43)) (let ((result (term-test-screen-from > (progn (ignore (null x44)) (let ((str x41) (expected x43)) (let ((re > (let* ((x43 (car-safe x42)) (x44 (cdr-safe x42))) (progn (ignore (nu > (progn (ignore (consp x42)) (let* ((x43 (car-safe x42)) (x44 (cdr-sa > (let* ((x41 (car-safe x40)) (x42 (cdr-safe x40))) (progn (ignore (co > (progn (ignore (consp x40)) (let* ((x41 (car-safe x40)) (x42 (cdr-sa > (let ((x40 (car tail))) (progn (ignore (consp x40)) (let* ((x41 (car > (while tail (let ((x40 (car tail))) (progn (ignore (consp x40)) (let > (let ((tail ansi-test-strings)) (while tail (let ((x40 (car tail))) > #f(lambda () [term-width term-height t] (let* ((fn-35 #'memq) (args- > #f(compiled-function () #)() > handler-bind-1(#f(compiled-function () # > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name term-colors :documentation nil :body > ert-run-or-rerun-test(#s(ert--stats :selector =2E=2E=2E :tests =2E=2E= =2E :test-m > ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type > ert-run-tests-batch((not (tag :unstable))) > ert-run-tests-batch-and-exit((not (tag :unstable))) > eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) > command-line-1(("-L" ":=2E" "-l" "ert" "--eval" "(setq treesit-extra-l > command-line() > normal-top-level() >Test term-colors condition: > (ert-test-failed > ((should > (equal (text-properties-at 0 result) > (text-properties-at 0 expected))) > :form (equal (font-lock-face (=2E=2E=2E)) (font-lock-face (=2E=2E= =2E))) :value > nil :explanation > (list-elt 1 > (list-elt 0 > (proper-lists-of-different-length 4 6 > =2E=2E=2E =2E=2E=2E first-mismatch-at > 2))))) > FAILED 2/12 term-colors (0=2E000633 sec) at lisp/term-tests=2Eel:13= 9 >Test term-colors-bold-is-bright backtrace: > signal(ert-test-failed (((should (equal (text-properties-at 0 result > ert-fail(((should (equal (text-properties-at 0 result) (text-propert > (if (unwind-protect (setq value-74 (apply fn-72 args-73)) (setq form > (let (form-description-76) (if (unwind-protect (setq value-74 (apply > (let ((value-74 'ert-form-evaluation-aborted-75)) (let (form-descrip > (let* ((fn-72 #'equal) (args-73 (condition-case err (list (text-prop > (let ((expected (or bright-expected expected)) (result (term-test-sc > (let ((str x61) (expected x63) (bright-expected x65)) (let ((expecte > (progn (ignore (null x66)) (let ((str x61) (expected x63) (bright-ex > (let* ((x65 (car-safe x64)) (x66 (cdr-safe x64))) (progn (ignore (nu > (progn (ignore (consp x64)) (let* ((x65 (car-safe x64)) (x66 (cdr-sa > (let* ((x63 (car-safe x62)) (x64 (cdr-safe x62))) (progn (ignore (co > (progn (ignore (consp x62)) (let* ((x63 (car-safe x62)) (x64 (cdr-sa > (let* ((x61 (car-safe x60)) (x62 (cdr-safe x60))) (progn (ignore (co > (progn (ignore (consp x60)) (let* ((x61 (car-safe x60)) (x62 (cdr-sa > (let ((x60 (car tail))) (progn (ignore (consp x60)) (let* ((x61 (car > (while tail (let ((x60 (car tail))) (progn (ignore (consp x60)) (let > (let ((tail ansi-test-strings)) (while tail (let ((x60 (car tail))) > (let ((ansi-color-bold-is-bright t)) (let ((tail ansi-test-strings)) > #f(lambda () [term-width term-height t] (let* ((fn-55 #'memq) (args- > #f(compiled-function () #)() > handler-bind-1(#f(compiled-function () # > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name term-colors-bold-is-bright :documenta > ert-run-or-rerun-test(#s(ert--stats :selector =2E=2E=2E :tests =2E=2E= =2E :test-m > ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type > ert-run-tests-batch((not (tag :unstable))) > ert-run-tests-batch-and-exit((not (tag :unstable))) > eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) > command-line-1(("-L" ":=2E" "-l" "ert" "--eval" "(setq treesit-extra-l > command-line() > normal-top-level() >Test term-colors-bold-is-bright condition: > (ert-test-failed > ((should > (equal (text-properties-at 0 result) > (text-properties-at 0 expected))) > :form (equal (font-lock-face (=2E=2E=2E)) (font-lock-face (=2E=2E= =2E))) :value > nil :explanation > (list-elt 1 > (list-elt 0 > (proper-lists-of-different-length 4 6 > =2E=2E=2E =2E=2E=2E first-mismatch-at > 2))))) > FAILED 3/12 term-colors-bold-is-bright (0=2E002501 sec) at lisp/ter= m-tests=2Eel:147 >--8<---------------cut here---------------end--------------->8--- Thanks=2E Looking at the traces in your message, ISTM the test should chan= ge=2E