From: Ken Raeburn <raeburn@raeburn.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/raeburn-startup 9919e41 2/2: Exclude comma symbols from print-symbols-as-references processing.
Date: Thu, 12 Jan 2017 14:30:58 -0500 [thread overview]
Message-ID: <6091F7D6-39C3-4B74-AD0D-C6DC96F94253@raeburn.org> (raw)
In-Reply-To: <jwv8tqgxwgx.fsf-monnier+emacsdiffs@gnu.org>
On Jan 12, 2017, at 08:03, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> + && ! EQ (Qcomma, obj) \
>> + && ! EQ (Qcomma_at, obj) \
>> + && ! EQ (Qcomma_dot, obj)))
>
> I can't think of any reason why the same problem wouldn't affect `quote'
> and `
They’re winding up in the table, too, but they get written out using printchar, while the comma symbols are written out using print_object, which will use the “#” forms. Or, rather, pairs starting with quote and ` are written out that way. Otherwise, my dumped.elc has #1=quote and #954=\`, and #1# and #954# are emitted like any other symbol.
Changing the printing of the comma symbols to use printchar probably would’ve worked as well. In fact, thinking on it, it might be cleaner, special-casing not the symbols but the generation of the special output syntax. I’ll have another look at that tonight.
Ken
prev parent reply other threads:[~2017-01-12 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170112064008.416.54060@vcs.savannah.gnu.org>
[not found] ` <20170112064008.F1C782201C9@vcs.savannah.gnu.org>
2017-01-12 13:03 ` [Emacs-diffs] scratch/raeburn-startup 9919e41 2/2: Exclude comma symbols from print-symbols-as-references processing Stefan Monnier
2017-01-12 19:30 ` Ken Raeburn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6091F7D6-39C3-4B74-AD0D-C6DC96F94253@raeburn.org \
--to=raeburn@raeburn.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).