From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master af4791b5706: Fix apparently wrong `delete` and `delq` value discards (bug#61730) Date: Thu, 25 May 2023 10:05:17 +0200 Message-ID: <609008CC-CABB-4FA2-84AB-6D8F4439AD91@acm.org> References: <83lehcnazb.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="901"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 25 10:06:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q25zB-000ATM-1v for ged-emacs-devel@m.gmane-mx.org; Thu, 25 May 2023 10:06:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q25yT-00054S-30; Thu, 25 May 2023 04:05:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q25yR-00054H-EG for emacs-devel@gnu.org; Thu, 25 May 2023 04:05:27 -0400 Original-Received: from mail1475c50.megamailservers.eu ([91.136.14.75] helo=mail118c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q25yO-0000Cq-Qm; Thu, 25 May 2023 04:05:27 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1685001919; bh=34aFkT52wc84+q6vlMZsY/FmuzOAq4B2X1gCb3It6+c=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=jS5GEJFNBDOW33iNz0aJyVdm1MGegvPtP3dJ+fApL6tzVvPkpiNHewUKvjZBBMnTQ Z4NJWRuM+FfXmlVMJ8ppTzN4sjD1CDyk/ulWXwAHuApGRJcg9TOBfYQuS6Bgv8hDa4 Bk6EF0Sp1RcTuEOpP7EZBmPVEmps/ciVxj8C48wE= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 34P85HgV100465; Thu, 25 May 2023 08:05:19 +0000 In-Reply-To: <83lehcnazb.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejiedguddviecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpeevkeffudejhfekhedvgfffieekgffhfedvkeeuffelgeefkeeulefhjeeifeekgfenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesghhnuhdrohhrgh X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.75; envelope-from=mattiase@acm.org; helo=mail118c50.megamailservers.eu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306319 Archived-At: 25 maj 2023 kl. 09.09 skrev Eli Zaretskii : > configvar-name is evidently a string, whereas the value returned by > delq is not a string at all. Do you understand why this code even > calls delq? I thought I did but may have been mistaken. Let's look at this again: =46rom the text of this function we can infer that `configvar-name` is = the name (symbol) of a dynamic variable whose value is a list of symbols = naming other variables. If we strip all the `boundp` and `delq` gunk, = this function essentially becomes (mapcar #'symbol-value (symbol-value configvar-name)) I don't fancy mutation of a list while it's being looped over any more = than you do, but I didn't want to touch it more than strictly necessary. > If it wants to change the value of configvar-name, it > should assign to (symbol-value configvar-name), no? It does. > And if all it > wants is to skip 'sym' and not add it to 'got', then there's no need > to call delq, right? As the yes-or-no-p call suggests, the intent is likely to remove unbound = entries permanently so there is no need to ask again in future calls, or = ask more than once for the same variable appearing in duplicate during = the same call.