From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.devel Subject: Re: master fd92023: Make checkdoc work with qualified methods Date: Mon, 08 Mar 2021 08:15:40 -0300 Message-ID: <6046075f.1c69fb81.17243.ba51@mx.google.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2656"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 08 12:16:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJDsC-0000Zf-A4 for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Mar 2021 12:16:28 +0100 Original-Received: from localhost ([::1]:40514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJDsB-0006Uk-CQ for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Mar 2021 06:16:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJDrb-0005yW-8a for emacs-devel@gnu.org; Mon, 08 Mar 2021 06:15:51 -0500 Original-Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:33573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJDrX-0001Yf-9i for emacs-devel@gnu.org; Mon, 08 Mar 2021 06:15:51 -0500 Original-Received: by mail-qk1-x730.google.com with SMTP id l4so8811843qkl.0 for ; Mon, 08 Mar 2021 03:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=fUdD4YnaKkaEs+RoRSV66MDUgYMAS96m2J1vc07THFg=; b=DPzOsx2yRQO58GN5ICZ41eazt6xVLLvm5z5+3hPkG8NkrIzQc+Eph5+WyPno4x1PLf fUwI3JX1JP5OCr3ILtrkrK1ecwQXXLeA0TdtgnJOutALYKYE0jdnRZoEownDjZXMWuJF aCN6wvKWBlVeTNy7w5ItPJ+ID/D08jRftVAs4HT2eJGBdh5AfkfW2uIDME0OhG1M1SFI OB/a5wufSV5OubBNFfPPM7rwYxvmbsBYc6Ce2mCh2PkLt/vvNEONUS83mcGJhutjnEXz FLGtBLvpCR9oqaGGljgXuxYm94SLiZvS/I8/GsFeQdGikEF/Rf5rN6Xij5xqGo5S9u+h hOmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=fUdD4YnaKkaEs+RoRSV66MDUgYMAS96m2J1vc07THFg=; b=a7XYHuvaqC8Xwk624oCMoO6BRh+G97gzlRbFVRC3STmyKIe855mGBoOVOACgSMnd4F sRtiba8+9zje/JjHmhg8iAjCzIzJegFJ0Ku16ZNCofqpoL6fM9N5VL+lCf5BccpCunnw cPqQK4+9+i5iYn2cvSHffW4xAAay+aBRg5UbkQyeQgd4UaFA8Wi4a7KlKg4ay1q4EYPH rubFrxfB3ZeL6QVOVh5VyAVxciT+SXnZ8OkNShuiUBNB8s6XHOf9dKQDO/zi+xNIK7dy eb7tHe0UU07VfEcTSdxmXGzc7Mu8GkbKwDwzCIKa28Bext59cUOTZ3r9LjUPDQ0UBJqI 3HOQ== X-Gm-Message-State: AOAM532nqi4yHW8XfEQUQ/br6oMIZ9u55zZxq5deLwJao3BS9qgGZ8Oq PEArJJqayPXlGnq1oWc/HlqVrmcMlPiYyQ== X-Google-Smtp-Source: ABdhPJyv1NZ0ajFDq0GYYv7zw3JWfLRwUUNGXCJ7ymLFVd0x+g+dT/sj2irmeFU1OgIK1zsfKOIwmw== X-Received: by 2002:a37:8b02:: with SMTP id n2mr20844764qkd.253.1615202144719; Mon, 08 Mar 2021 03:15:44 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id g6sm7310432qtg.91.2021.03.08.03.15.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Mar 2021 03:15:43 -0800 (PST) X-Google-Original-Message-ID: <87o8ftc2w3.fsf@maurooaranda@gmail.com> In-Reply-To: (message from Stefan Monnier on Fri, 05 Mar 2021 20:03:07 -0500) Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=maurooaranda@gmail.com; helo=mail-qk1-x730.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266172 Archived-At: Stefan Monnier writes: >>> and then check that (function-get def 'doc-string-elt) is non-nil. >> >> I thought about that: it would "add support" to other definitions, and I >> wasn't sure if it would be desired to check the docstring for all of them. > > No idea either, but it seems worth a try. Very well, I've made the change to checkdoc--next-docstring to check for a non-nil doc-string-elt property and use it.