From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Shall menu_bar_items and tool_bar_items look at text property keymaps? Date: 20 Feb 2002 16:28:13 +0100 Message-ID: <5xy9hoi35e.fsf@kfs2.cua.dk> References: <5x8z9yfdvz.fsf@kfs2.cua.dk> <200202140312.g1E3CIH09137@aztec.santafe.edu> <5xvgd0e8zq.fsf@kfs2.cua.dk> <200202151036.g1FAacl07300@santafe.santafe.edu> <5xk7tfgeim.fsf@kfs2.cua.dk> <200202162156.g1GLu4M09951@aztec.santafe.edu> NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1014219060 18140 195.204.10.66 (20 Feb 2002 15:31:00 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 20 Feb 2002 15:31:00 GMT Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16dYhv-0004iU-00 for ; Wed, 20 Feb 2002 16:30:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16dYhH-0004T6-00; Wed, 20 Feb 2002 10:30:19 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.33 #1 (Debian)) id 16dYeB-0004E5-00 for ; Wed, 20 Feb 2002 10:27:07 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id 8987F7C047 for ; Wed, 20 Feb 2002 15:27:04 +0000 (GMT) Original-To: emacs-devel@gnu.org In-Reply-To: <200202162156.g1GLu4M09951@aztec.santafe.edu> Original-Lines: 24 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1361 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1361 Richard Stallman writes: > Instead of trying to make it work (which will involve a severe performance > penalty), I suggest to remove the code and document in the Elisp manual > that those text property maps don't support menu-bar and tool-bar bindings. > > Documenting that seems like a good idea. Is there special code > that attempts to make it work but fails? If so, put it in #if 0 > and with a comment explaining why it doesn't work and why > working correctly is hard. I have changed menu_bar_items and tool_bar_items in keyboard.c to not look for keymap and local-map properties, and I have added comments to the code explaining why we don't look at those maps. I'll discuss with Eli how to fix the documentation in the lisp ref. However, the old code wasn't really correct (it looked at the keymaps in the wrong order), so instead of keeping the (messy/buggy) old code, I have replaced it with simpler and cleaner code which handles just the "normal" keymaps. I hope that is ok. -- Kim F. Storm http://www.cua.dk _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel