From: storm@cua.dk (Kim F. Storm)
Subject: Re: Shall menu_bar_items and tool_bar_items look at text property keymaps?
Date: 20 Feb 2002 16:28:13 +0100 [thread overview]
Message-ID: <5xy9hoi35e.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <200202162156.g1GLu4M09951@aztec.santafe.edu>
Richard Stallman <rms@gnu.org> writes:
> Instead of trying to make it work (which will involve a severe performance
> penalty), I suggest to remove the code and document in the Elisp manual
> that those text property maps don't support menu-bar and tool-bar bindings.
>
> Documenting that seems like a good idea. Is there special code
> that attempts to make it work but fails? If so, put it in #if 0
> and with a comment explaining why it doesn't work and why
> working correctly is hard.
I have changed menu_bar_items and tool_bar_items in keyboard.c to not
look for keymap and local-map properties, and I have added comments to
the code explaining why we don't look at those maps.
I'll discuss with Eli how to fix the documentation in the lisp ref.
However, the old code wasn't really correct (it looked at the keymaps
in the wrong order), so instead of keeping the (messy/buggy) old code,
I have replaced it with simpler and cleaner code which handles just
the "normal" keymaps. I hope that is ok.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
prev parent reply other threads:[~2002-02-20 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-13 0:01 Shall menu_bar_items and tool_bar_items look at text property keymaps? Kim F. Storm
2002-02-13 16:52 ` Stefan Monnier
2002-02-13 21:26 ` Kim F. Storm
2002-02-14 3:12 ` Richard Stallman
2002-02-14 8:57 ` Kim F. Storm
2002-02-15 10:36 ` Richard Stallman
2002-02-15 11:39 ` Kim F. Storm
2002-02-16 21:56 ` Richard Stallman
2002-02-20 15:28 ` Kim F. Storm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xy9hoi35e.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).