errors in cus-load.el ?

errors in cus-load.el ?

[Kim F. Storm]

I was looking at cus-load.el, and there are some things in there which
I think might point to errors in other files:

1) Shouldn't the version number be a string in these settings?

(custom-put-if-not 'ange-ftp-passive-host-alist 'custom-version 21.3)
(custom-put-if-not 'ange-ftp-try-passive-mode 'custom-version 21.1)
(custom-put-if-not 'xscheme-start-hook 'custom-version 20.3)

The next questions may simply be answered by fixing the problems
caused by first question

2) Same question here: 

(defvar custom-versions-load-alist '((20.3 "xscheme") ... 
        (21.1 "ange-ftp") ("21.3" "replace")... (21.3 "ange-ftp") ...))

3) why does "ange-ftp" occur twice in this list

4) shouldn't "ange-ftp" be merged with "replace" in the "21.3" list.


-- 
Kim F. Storm  http://www.cua.dk


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: errors in cus-load.el ?

[Andreas Schwab]

no-spam@cua.dk (Kim F. Storm) writes:

|> I was looking at cus-load.el, and there are some things in there which
|> I think might point to errors in other files:
|> 
|> 1) Shouldn't the version number be a string in these settings?
|> 
|> (custom-put-if-not 'ange-ftp-passive-host-alist 'custom-version 21.3)
|> (custom-put-if-not 'ange-ftp-try-passive-mode 'custom-version 21.1)
|> (custom-put-if-not 'xscheme-start-hook 'custom-version 20.3)

This has popped up before, see customize-version-lessp:

(defun customize-version-lessp (version1 version2)
  ;; Why are the versions strings, and given that they are, why aren't
  ;; they converted to numbers and compared as such here?  -- fx

  ;; In case someone made a mistake and left out the quotes
  ;; in the :version value.

|> 2) Same question here: 
|> 
|> (defvar custom-versions-load-alist '((20.3 "xscheme") ... 
|>         (21.1 "ange-ftp") ("21.3" "replace")... (21.3 "ange-ftp") ...))
|> 
|> 3) why does "ange-ftp" occur twice in this list

Because (not (equal 21.1 21.3)).

|> 4) shouldn't "ange-ftp" be merged with "replace" in the "21.3" list.

No, because (not (equal "21.3" 21.3)).

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel