unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: no-spam@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Shall menu_bar_items and tool_bar_items look at text property keymaps?
Date: 14 Feb 2002 09:57:29 +0100	[thread overview]
Message-ID: <5xvgd0e8zq.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <200202140312.g1E3CIH09137@aztec.santafe.edu>

Richard Stallman <rms@gnu.org> writes:

>     I was looking at the above functions and wondered whether it really
>     makes sense for those functions to look for menu-bar and tool-bar
>     bindings in the keymap and local-map properties of PT in the current
>     buffer?
> 
> This could cause a substantial slowdown if it means that Emacs
> has to recompute the menus based on the current value of point.
> The usefulness of the feature seems marginal, which suggests it 
> is better not to pay that price, better not to add that feature.

I asked the question because those functions already DO LOOK for
those bindings - but the rest of emacs doesn't call those functions
often enough for the functionality to work anyway.

Since it doesn't really work, I doubt anyone is actually using it.

So my proposal is to remove the "look for keymaps at PT" from those
functions.

++kfs


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel


  reply	other threads:[~2002-02-14  8:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-13  0:01 Shall menu_bar_items and tool_bar_items look at text property keymaps? Kim F. Storm
2002-02-13 16:52 ` Stefan Monnier
2002-02-13 21:26   ` Kim F. Storm
2002-02-14  3:12 ` Richard Stallman
2002-02-14  8:57   ` Kim F. Storm [this message]
2002-02-15 10:36     ` Richard Stallman
2002-02-15 11:39       ` Kim F. Storm
2002-02-16 21:56         ` Richard Stallman
2002-02-20 15:28           ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5xvgd0e8zq.fsf@kfs2.cua.dk \
    --to=no-spam@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).