From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [PATCHES] patches for compiling GNU emacs 21.2 under Cygwin Date: 04 Dec 2002 00:16:25 +0100 Sender: emacs-devel-admin@gnu.org Message-ID: <5xvg2apuba.fsf@kfs2.cua.dk> References: <7263-Wed27Nov2002204304+0200-eliz@is.elta.co.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1038953933 24013 80.91.224.249 (3 Dec 2002 22:18:53 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 3 Dec 2002 22:18:53 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18JLNT-0006F6-00 for ; Tue, 03 Dec 2002 23:18:51 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18JLX9-0006pT-00 for ; Tue, 03 Dec 2002 23:28:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18JLMj-00060h-00; Tue, 03 Dec 2002 17:18:05 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18JLLW-000480-00 for emacs-devel@gnu.org; Tue, 03 Dec 2002 17:16:50 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18JLLQ-0003xg-00 for emacs-devel@gnu.org; Tue, 03 Dec 2002 17:16:48 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18JLLP-0003ph-00 for emacs-devel@gnu.org; Tue, 03 Dec 2002 17:16:43 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 07D737C017; Tue, 3 Dec 2002 22:16:41 +0000 (GMT) Original-To: Joe Buehler In-Reply-To: Original-Lines: 44 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:9845 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:9845 Joe Buehler writes: > Eli Zaretskii wrote: > > > Please provide ChangeLog entries for each change. > > I'll check the web for instructions on how to do that. > > > Please also explain the changes the reason for which is not > > self-evident. For example, in this change to Makefile.in: > > - (cd $(docdir); chmod a+r DOC*; rm DOC); \ > > + (cd ${docdir}; chmod a+r DOC*; if test "`echo DOC-*`" != "DOC-*"; \ > > + then rm DOC; fi); \ > > why is it necessary to add this test? Is there something special in > > the way the Cygwin port of Bash expands wildcards? > > There are bugs in emacs (both build/install and runtime) if you cannot > undump. I assume that CANNOT_UNDUMP has not been tested in a while, since > the bugs should show up regardless of platform. > > The above fix is because no DOC-* file is installed by "make install" > when CANNOT_UNDUMP. Only a DOC file is, and that promptly gets removed > without the above patch. I installed this fix on HEAD back in August. > > > The purpose of this change is also not clear enough: > > +#ifdef CANNOT_DUMP > > + FRAME_FOREGROUND_PIXEL(f) = FACE_TTY_DEFAULT_FG_COLOR; > > + FRAME_BACKGROUND_PIXEL(f) = FACE_TTY_DEFAULT_BG_COLOR; > > +#endif > > What is special about systems that cannot dump that requires this > > fragment? > > If you look at the code, you will see that there is no code path that > initializes the frame foreground and background pixels when CANNOT_UNDUMP > is in effect. So you end up with black on black, which is of course > unreadable. It took me a while to find this, but that's what is going on. I installed this fix on HEAD back in August, too. -- Kim F. Storm http://www.cua.dk