From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Bold by moving pixels problem Date: 19 Dec 2002 13:18:55 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xu1ha42xc.fsf@kfs2.cua.dk> References: <20021120220834.GC29543@gnu.org> <200211210133.gAL1XiP23941@rum.cs.yale.edu> <5xfzsvqzqx.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1040296880 1606 80.91.224.249 (19 Dec 2002 11:21:20 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 19 Dec 2002 11:21:20 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18Oyjl-0000PK-00 for ; Thu, 19 Dec 2002 12:21:09 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18Oykr-00073h-00 for ; Thu, 19 Dec 2002 12:22:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18OyjA-0001yE-03 for emacs-devel@quimby.gnus.org; Thu, 19 Dec 2002 06:20:32 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18Oyie-0001hK-00 for emacs-devel@gnu.org; Thu, 19 Dec 2002 06:20:00 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18Oyib-0001ae-00 for emacs-devel@gnu.org; Thu, 19 Dec 2002 06:19:59 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Oyi7-0000yr-00; Thu, 19 Dec 2002 06:19:27 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id 0C28E7C012; Thu, 19 Dec 2002 12:19:18 +0100 (CET) Original-To: Miles Bader In-Reply-To: Original-Lines: 40 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-cc: bob@rattlesnake.com X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10276 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10276 Miles Bader writes: > storm@cua.dk (Kim F. Storm) writes: > > I've looked at your patch, and it seems to be very low-level to give > > the filter functions direct access to the actual lface vector elements. > > Well, it's a low-level thing... :-) > > > I'd suggest a different approach using the internal-lisp-face attribute > > names that are already defined in xfaces.c such as :family, :height, etc. > > I agree, code filled with `(aref .. 3)' is not good. Going all the > way to a plist seems a bit gratuitous though. IMHO, the only argument for the current implementation vs. a plist would be performance. > > What about just providing accessor/setter macros for `lface' vectors, > e.g., (lface-weight LFACE) and (set-lface-weight LFACE VAL)? IMO, That's just adding stuff to remedy the wrong approach; the plist approach doesn't need adding _any_ new stuff at the lisp level. > > After all the `lface' representation _is_ exposed to lisp already, so > such macros might help other code as well. Excuse my ignorance, but where is that exposed already? > > [I'm not sure about the term `lface' though -- it's used fairly > pervasively in the C code, but of course that's from the perspective of > the C code...] It seems to be called (internal-)lisp-face in stuff like internal-make-lisp-face (try apropos on "internal lisp face"). lisp-face-vector may be a good name? -- Kim F. Storm http://www.cua.dk