From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Updated Patch for command remapping through keymaps Date: 07 Feb 2002 00:44:30 +0100 Message-ID: <5xsn8ech0h.fsf@kfs2.cua.dk> References: <5xvgdngssk.fsf@kfs2.cua.dk> <5x665fe4t0.fsf@kfs2.cua.dk> <200202040926.g149Qvf02362@aztec.santafe.edu> <5xwuxsrxgl.fsf@kfs2.cua.dk> <200202061354.g16DsLt04019@aztec.santafe.edu> <5x3d0ee237.fsf@kfs2.cua.dk> NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1013039602 9884 195.204.10.66 (6 Feb 2002 23:53:22 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 6 Feb 2002 23:53:22 GMT Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16YbsP-0002ZK-00 for ; Thu, 07 Feb 2002 00:53:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16Ybkf-0008JT-00; Wed, 06 Feb 2002 18:45:21 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.33 #1 (Debian)) id 16Ybid-0008Bc-00 for ; Wed, 06 Feb 2002 18:43:15 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 32DD37C035 for ; Wed, 6 Feb 2002 23:43:14 +0000 (GMT) Original-To: emacs-devel@gnu.org In-Reply-To: <5x3d0ee237.fsf@kfs2.cua.dk> Original-Lines: 28 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:830 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:830 storm@cua.dk (Kim F. Storm) writes: > Richard Stallman writes: > > > However, I don't really understand the lack of GCPRO in some of the > > functions in keymap.c. Specifically, I would have expected GCPRO > > before the calls to > > keymap = get_keymap (..., ..., 1); > > in > > Fset_keymap_parent (parent) > > > > You are right. This was not needed in the past, but now that > > get_keymap can autoload and thus run Lisp code, the gcpro is needed. > > Could someone add that? > > I will do that as soon as I have committed my current set of patches. Well, I have looked at it, and it is more complicated than that. If get_keymap can GC, then all the functions which calls it can also GC - and so on. For example, functions calling Fkeymap_parent may also GC. I think fixing this requires a better understanding of the relationships between these functions, so the maintainer of keymap.c should make the changes. -- Kim F. Storm http://www.cua.dk _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel