From: storm@cua.dk (Kim F. Storm)
Subject: Re: Updated Patch for command remapping through keymaps
Date: 07 Feb 2002 00:44:30 +0100 [thread overview]
Message-ID: <5xsn8ech0h.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <5x3d0ee237.fsf@kfs2.cua.dk>
storm@cua.dk (Kim F. Storm) writes:
> Richard Stallman <rms@gnu.org> writes:
>
> > However, I don't really understand the lack of GCPRO in some of the
> > functions in keymap.c. Specifically, I would have expected GCPRO
> > before the calls to
> > keymap = get_keymap (..., ..., 1);
> > in
> > Fset_keymap_parent (parent)
> >
> > You are right. This was not needed in the past, but now that
> > get_keymap can autoload and thus run Lisp code, the gcpro is needed.
> > Could someone add that?
>
> I will do that as soon as I have committed my current set of patches.
Well, I have looked at it, and it is more complicated than that. If
get_keymap can GC, then all the functions which calls it can also GC -
and so on. For example, functions calling Fkeymap_parent may also GC.
I think fixing this requires a better understanding of the relationships
between these functions, so the maintainer of keymap.c should make the
changes.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next parent reply other threads:[~2002-02-06 23:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5xvgdngssk.fsf@kfs2.cua.dk>
[not found] ` <5x665fe4t0.fsf@kfs2.cua.dk>
[not found] ` <200202040926.g149Qvf02362@aztec.santafe.edu>
[not found] ` <5xwuxsrxgl.fsf@kfs2.cua.dk>
[not found] ` <200202061354.g16DsLt04019@aztec.santafe.edu>
[not found] ` <5x3d0ee237.fsf@kfs2.cua.dk>
2002-02-06 23:44 ` Kim F. Storm [this message]
2002-02-07 9:42 ` Updated Patch for command remapping through keymaps Eli Zaretskii
2002-02-07 14:18 ` Stefan Monnier
2002-02-08 13:57 ` Richard Stallman
2002-02-08 13:57 ` Richard Stallman
2002-02-08 15:00 ` Stefan Monnier
2002-02-10 5:19 ` Richard Stallman
2002-02-10 15:52 ` Stefan Monnier
2002-02-11 18:47 ` Richard Stallman
2002-02-07 9:39 ` Juanma Barranquero
2002-02-07 11:29 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xsn8ech0h.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).