unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: no-spam@cua.dk (Kim F. Storm)
Subject: Exit status inserted in shell command output buffer
Date: 25 Feb 2002 14:21:45 +0100	[thread overview]
Message-ID: <5xsn7pvgra.fsf@kfs2.cua.dk> (raw)


I don't like the new `functionality' which adds the line
"...Shell command failed with code X"
to the *Shell Command Output* buffer when a command returns
a non-zero exit status.

I think these are the relevant changes:

2002-02-20  Richard M. Stallman  <rms@gnu.org>

	* simple.el (shell-command-on-region): Display the exit status
	when a command fails.

2001-12-13  Richard M. Stallman  <rms@gnu.org>

	* simple.el
	(shell-command-on-region): If there is output an an error,
	add "...Shell command failed" to the output.


In my mind, if a command produces output, emacs shouldn't modify
(i.e. add to) the output from the command!

What do others think?

Example:

Index: shell.el
===================================================================
RCS file: /cvs/emacs/lisp/shell.el,v
retrieving revision 1.106
retrieving revision 1.107
diff -r1.106 -r1.107
318c318,319
< 	 (copy-keymap (lookup-key comint-mode-map [menu-bar completion])))
---
> 	 (cons "Complete" 
> 	       (copy-keymap (lookup-key comint-mode-map [menu-bar completion]))))
..Shell command failed with code 1


So `cvs diff' exited with code 1 because the two revisions differ.
But in my mind, the command didn't fail -- it worked just fine.
The first time I saw this, I thought that there was actually some
error causing the diff output to have been truncated....


++kfs


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel


             reply	other threads:[~2002-02-25 13:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-25 13:21 Kim F. Storm [this message]
2002-02-25 13:58 ` Exit status inserted in shell command output buffer Kim F. Storm
2002-02-26 20:14   ` Richard Stallman
2002-02-27 18:07     ` Ehud Karni
2002-02-27 23:37     ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5xsn7pvgra.fsf@kfs2.cua.dk \
    --to=no-spam@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).