From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Command remapping and the delete-frame problem.
Date: 22 Feb 2002 16:40:42 +0100 [thread overview]
Message-ID: <5xpu2xv81x.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <5xd6yx965v.fsf_-_@kfs2.cua.dk>
Earlier today, I wrote:
>
> Are you now saying that remapping should have been implemented
> using a specific `command' prefix like this:
>
> (define-key map [command command1] 'command2)
>
> I can see that this is better than the current implementation as it
> makes a clear destinction (in the keymaps) between commands and other
> symbols like those used on the menu-bar, and a few symbols which are
> both commands and keys (e.g. `undo').
>
> All of this makes a lot of sense -- should I go back and change the
> implementation to use an explicit `command' prefix for command
> remapping?
Actually, I went ahead an made the changes in a fully transparent way.
This means that internally, remapping command FOO to BAR is stored as
a binding for [command FOO], i.e. the "event" `command' is bound to a
keymap in which FOO is mapped to BAR.
But the interface to define-key, lookup-key and key-binding hasn't
changed. They just take FOO as the KEY argument - which is still an
unambuguous way to represent command remapping, as those functions
don't otherwise accept a symbol as the KEY argument.
The changes are very small, so I expect to commit them later this
evening.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next parent reply other threads:[~2002-02-22 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5x3czwjqxs.fsf@kfs2.cua.dk>
[not found] ` <7263-Wed20Feb2002194728+0200-eliz@is.elta.co.il>
[not found] ` <5xd6yzwxs8.fsf@kfs2.cua.dk>
[not found] ` <200202220433.g1M4XP414080@aztec.santafe.edu>
[not found] ` <5xd6yx965v.fsf_-_@kfs2.cua.dk>
2002-02-22 15:40 ` Kim F. Storm [this message]
2002-02-22 16:24 ` Command remapping and the delete-frame problem Stefan Monnier
2002-02-22 19:31 ` Kim F. Storm
2002-02-22 19:38 ` Stefan Monnier
2002-02-23 20:19 ` Richard Stallman
2002-02-24 0:41 ` Kim F. Storm
2002-03-03 17:25 ` Tak Ota
2002-03-04 23:41 ` Richard Stallman
2002-03-05 6:19 ` Tak Ota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xpu2xv81x.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).