From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: regexp case sensitivity bug
Date: 10 Dec 2002 01:45:17 +0100 [thread overview]
Message-ID: <5xptsad7mq.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <3DF518E2.6FDE0A01@cs.unc.edu>
Dean Herington <heringto@cs.unc.edu> writes:
> Richard Stallman wrote:
>
> > In Emacs 21.1.1, when I do isearch-forward-regexp with input "\bP",
> > Emacs matches 'p's case insensitively.
> >
> > Does this patch fix it?
> >
> > *** isearch.el.~1.215.~ Sun Nov 10 13:13:37 2002
> > --- isearch.el Mon Dec 9 11:20:37 2002
> > ***************
> > *** 1871,1877 ****
> > (if (and regexp-flag (eq char ?\\))
> > (setq quote-flag (not quote-flag))
> > (if (and (not quote-flag) (not (eq char (downcase char))))
> > ! (setq found t))))
> > (setq i (1+ i)))
> > (not found)))
> >
> > --- 1871,1878 ----
> > (if (and regexp-flag (eq char ?\\))
> > (setq quote-flag (not quote-flag))
> > (if (and (not quote-flag) (not (eq char (downcase char))))
> > ! (setq found t))
> > ! (setq quote-flag nil)))
> > (setq i (1+ i)))
> > (not found)))
>
> That patch fixes the bug I saw.
>
> How about the following, which I find simpler?
>
> (defun isearch-no-upper-case-p (string regexp-flag)
> "Return t if there are no upper case chars in STRING.
> If REGEXP-FLAG is non-nil, disregard letters quoted by `\\'
> since they have special meaning in a regexp."
> (let ((i 0) (len (length string)) found)
> (while (and (not found) (< i len))
> (let ((char (aref string i)))
> (if (and regexp-flag (eq char ?\\))
> (setq i (1+ i))
> (if (not (eq char (downcase char)))
> (setq found t))))
> (setq i (1+ i)))
> (not found)))
>
Or we can use a completely different approach:
(defun isearch-no-upper-case-p (string regexp-flag)
"..."
(let ((case-fold-search nil))
(save-match-data
(null (string-match
(if regexp-flag "\\(^\\|[^\\]\\)[[:upper:]]" "[[:upper:]]")
string)))))
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2002-12-10 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3DF3B4D0.D4628D27@cs.unc.edu>
2002-12-09 20:22 ` regexp case sensitivity bug Richard Stallman
2002-12-09 22:27 ` Dean Herington
2002-12-10 0:45 ` Kim F. Storm [this message]
2002-12-10 10:52 ` Andreas Schwab
2002-12-10 21:30 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xptsad7mq.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).