From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5 Date: 05 Jan 2003 01:31:10 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xptrcjv3l.fsf@kfs2.cua.dk> References: <3E15B803.8080507@hekimian.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1041723136 11724 80.91.224.249 (4 Jan 2003 23:32:16 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 4 Jan 2003 23:32:16 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18Uxm2-00032y-00 for ; Sun, 05 Jan 2003 00:32:14 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18UxpI-0003Ds-00 for ; Sun, 05 Jan 2003 00:35:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Uxlt-0004eW-04 for emacs-devel@quimby.gnus.org; Sat, 04 Jan 2003 18:32:05 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18UxlZ-0004dc-00 for emacs-devel@gnu.org; Sat, 04 Jan 2003 18:31:45 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18UxlW-0004cc-00 for emacs-devel@gnu.org; Sat, 04 Jan 2003 18:31:45 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18UxlV-0004cB-00; Sat, 04 Jan 2003 18:31:42 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 5FF667C012; Sun, 5 Jan 2003 00:31:39 +0100 (CET) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 22 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-cc: eliz@is.elta.co.il Original-cc: joseph.buehler@spirentcom.com X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10485 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10485 Richard Stallman writes: > The above usage in pop.c does not seem correct to me -- aren't symbols > beginning with _ supposed to be reserved for the compilation system, to avoid > conflicts such as this one? > > Yes, I thyink that is true. Perhaps we should change Emacs to use P > instead of _P. But that is a rather large change, albeit not a very > deep one. We already use P_ in most cases (under src/), and __P in a few other cases (mostly under lib-src/ and lwlib/). So it seems a bit odd that pop.c (as the only file) uses _P. I suggest we simply change pop.c to use __P like the other files in lib-src. Shall I make that change? -- Kim F. Storm http://www.cua.dk