From: storm@cua.dk (Kim F. Storm)
Subject: Re: Exit status inserted in shell command output buffer
Date: 25 Feb 2002 14:58:30 +0100 [thread overview]
Message-ID: <5xofidvf21.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <5xsn7pvgra.fsf@kfs2.cua.dk>
I recently wrote:
> I don't like the new `functionality' which adds the line
> "...Shell command failed with code X"
> to the *Shell Command Output* buffer when a command returns
> a non-zero exit status.
>
> In my mind, if a command produces output, emacs shouldn't modify
> (i.e. add to) the output from the command!
The following patch places the Exit code in the mode line of the
*Shell Command Output* buffer (using the `mode-line-process' variable).
So it's shown to the users interested in such things, but don't
mess with the buffer...
What do you think?
(The following patch was inserted here with insert-buffer without
manually having to delete the ...Shell command failed line :-)
Index: simple.el
===================================================================
RCS file: /cvs/emacs/lisp/simple.el,v
retrieving revision 1.522
diff -c -r1.522 simple.el
*** simple.el 20 Feb 2002 22:33:01 -0000 1.522
--- simple.el 25 Feb 2002 13:56:02 -0000
***************
*** 1475,1490 ****
nil shell-command-switch command)))
(setq success (and exit-status (equal 0 exit-status)))
;; Report the output.
(if (with-current-buffer buffer (> (point-max) (point-min)))
;; There's some output, display it
! (progn
! (if (not success)
! (with-current-buffer buffer
! (save-excursion
! (goto-char (point-max))
! (insert (format "...Shell command failed with code %d"
! exit-status)))))
! (display-message-or-buffer buffer))
;; No output; error?
(let ((output
(if (and error-file
--- 1475,1487 ----
nil shell-command-switch command)))
(setq success (and exit-status (equal 0 exit-status)))
;; Report the output.
+ (with-current-buffer buffer
+ (setq mode-line-process
+ (if (not success)
+ (concat (format " - Exit [%d]" exit-status)))))
(if (with-current-buffer buffer (> (point-max) (point-min)))
;; There's some output, display it
! (display-message-or-buffer buffer)
;; No output; error?
(let ((output
(if (and error-file
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2002-02-25 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-25 13:21 Exit status inserted in shell command output buffer Kim F. Storm
2002-02-25 13:58 ` Kim F. Storm [this message]
2002-02-26 20:14 ` Richard Stallman
2002-02-27 18:07 ` Ehud Karni
2002-02-27 23:37 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xofidvf21.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).