unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: input-pending-p
Date: 06 Jun 2002 00:00:32 +0200	[thread overview]
Message-ID: <5xofepbd33.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <200205272302.g4RN2Bm06859@Rednose.Rhubarb>

David <dajo@Rednose.Rhubarb> writes:

> I think that I have found out the cause of this problem.  I *have*
> found out how to solve the problem from my point of view.  Currently I
> am testing to the extent possible.  Please be aware that I do not have
> a comfortable grasp of what is happening in Emacs; what I write and
> what I have done is inspired guesswork.
> 
> If you have any commentary I shall be pleased to receive it.  I am
> especially interested in knowing if this problem will be addressed in
> future releases.
> 
> It seems that Gnome/sawfish is fond of generating FOCUS_IN_EVENT
> events (and other stuff - Emacs gets quite busy).  These events then
> are put into the Emacs event queue and result in a positive yield from
> input-pending-p when really there is nothing there.  The problem does
> not arise with fvwm, twm, etc because they do not generate the
> FOCUS_IN_EVENT events.

Hi David,

From your analysis, it does indeed seem like excessive FocusIn events
are confusing emacs.  However, your patch is a bit radical (as it
effectively ignores those events).

Please try the following patch to see if it solves the problem.  This
is from the latest CVS version, but should apply directly to 21.2.
Remember to undo your own patch before testing.

Index: xterm.c
===================================================================
RCS file: /cvs/emacs/src/xterm.c,v
retrieving revision 1.735
diff -c -r1.735 xterm.c
*** xterm.c	28 May 2002 20:27:59 -0000	1.735
--- xterm.c	5 Jun 2002 20:53:20 -0000
***************
*** 10784,10790 ****
  	      f = x_any_window_to_frame (dpyinfo, event.xfocus.window);
  	      if (event.xfocus.detail != NotifyPointer)
  		dpyinfo->x_focus_event_frame = f;
! 	      if (f)
  		{
  		  x_new_focus_frame (dpyinfo, f);
  
--- 10784,10790 ----
  	      f = x_any_window_to_frame (dpyinfo, event.xfocus.window);
  	      if (event.xfocus.detail != NotifyPointer)
  		dpyinfo->x_focus_event_frame = f;
! 	      if (f && f != dpyinfo->x_focus_frame)
  		{
  		  x_new_focus_frame (dpyinfo, f);
  
++kfs


> 
> >  - Function: input-pending-p
> >      This function determines whether any command input is currently
> >      available to be read.  It returns immediately, with value `t' if
> >      there is available input, `nil' otherwise.  On rare occasions it
> >      may return `t' when no input is available.
> > 
> > You might like to know that this function is, newly, giving me trouble
> > so that the "rare occasions" occur exactly 50% of the time.  I am
> > calling the function in small (1-5) bursts and the value yielded by
> > input-pending-p is predictably and reliably nil on the odd-numbered
> > calls and t on the even numbered calls.  Under the conditions that
> > pertain the value always should be nil.
> > 
> > The code that, now, is failing is years old, has been in use
> > sucessfully for years, and, what is interesting, now performs like
> > this.
> > 
> > Emacs 20.7, window managers twm, fvwm, Gnome:  works properly
> > Emacs 21.1, window managers twm, fvwm:         works properly
> > Emacs 21.1, window managers Gnome, KDE:        fails as indicated
> > It is difficult for me to check KDE and 20.7 at the moment.
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel
> 
> 

  reply	other threads:[~2002-06-05 22:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200203070326.g273Q6A02247@Rednose.Rhubarb>
2002-03-10 21:32 ` input-pending-p Richard Stallman
2002-03-24 23:50   ` input-pending-p David
2002-03-25  6:24     ` input-pending-p Eli Zaretskii
2002-03-25 12:01     ` input-pending-p Richard Stallman
2002-05-27 23:02   ` input-pending-p David
2002-06-05 22:00     ` Kim F. Storm [this message]
2002-06-09 16:16       ` input-pending-p David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5xofepbd33.fsf@kfs2.cua.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).