unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org, jimb@red-bean.com
Subject: Re: [jimb@red-bean.com: Redisplay bug in 21.2.90.1]
Date: 15 Jun 2002 00:54:45 +0200	[thread overview]
Message-ID: <5xofedxyh6.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <200206141547.g5EFlc208922@aztec.santafe.edu>

Richard Stallman <rms@gnu.org> writes:

>     I just committed a fix on HEAD.
> 
> Thanks.
> 
>     I guess it isn't serious enough to include on RC branch...?
> 
> Maybe it is--it depends how safe the fix is. 

I think the fix is quite safe.

I actually added the fix in three different functions which
inserts text in a buffer.  Only one of these funtions was 
responsible for the behaviour reported by Jim.


> Could you show us the fix?
> 

Index: insdel.c
===================================================================
RCS file: /cvs/emacs/src/insdel.c,v
retrieving revision 1.166
retrieving revision 1.167
diff -c -r1.166 -r1.167
*** insdel.c	9 Feb 2002 22:57:25 -0000	1.166
--- insdel.c	13 Jun 2002 22:07:13 -0000	1.167
***************
*** 1031,1036 ****
--- 1031,1040 ----
    if (GPT_BYTE < GPT)
      abort ();
  
+   /* The insert may have been in the unchanged region, so check again. */
+   if (Z - GPT < END_UNCHANGED)
+     END_UNCHANGED = Z - GPT;
+ 
    adjust_overlays_for_insert (PT, nchars);
    adjust_markers_for_insert (PT, PT_BYTE,
  			     PT + nchars, PT_BYTE + nbytes,
***************
*** 1154,1159 ****
--- 1158,1167 ----
    if (GPT_BYTE < GPT)
      abort ();
  
+   /* The insert may have been in the unchanged region, so check again. */
+   if (Z - GPT < END_UNCHANGED)
+     END_UNCHANGED = Z - GPT;
+ 
    adjust_overlays_for_insert (PT, nchars);
    adjust_markers_for_insert (PT, PT_BYTE, PT + nchars,
  			     PT_BYTE + outgoing_nbytes,
***************
*** 1300,1305 ****
--- 1308,1317 ----
  
    if (GPT_BYTE < GPT)
      abort ();
+ 
+   /* The insert may have been in the unchanged region, so check again. */
+   if (Z - GPT < END_UNCHANGED)
+     END_UNCHANGED = Z - GPT;
  
    adjust_overlays_for_insert (PT, nchars);
    adjust_markers_for_insert (PT, PT_BYTE, PT + nchars,

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2002-06-14 22:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-11  7:30 [jimb@red-bean.com: Redisplay bug in 21.2.90.1] Kim F. Storm
2002-06-13 23:14 ` Kim F. Storm
2002-06-14  1:06   ` Jim Blandy
2002-06-14 15:47   ` Richard Stallman
2002-06-14 22:54     ` Kim F. Storm [this message]
2002-06-15 21:47       ` Richard Stallman
2002-06-17 22:35         ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5xofedxyh6.fsf@kfs2.cua.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).