From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] allow function values for `enable-local-eval' Date: 04 Jul 2002 23:58:44 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <5xofdnb1ez.fsf@kfs2.cua.dk> References: <200206281741.g5SHfAa04345@santafe.santafe.edu> <87u1nnnqlp.fsf@floss.i-did-not-set--mail-host-address--so-shoot-me> <5xit42rjic.fsf@kfs2.cua.dk> <200206292222.g5TMMKx10256@santafe.santafe.edu> <5x8z4wzbw7.fsf@kfs2.cua.dk> <200207011410.g61EA0Q07792@aztec.santafe.edu> <5xr8inrvgr.fsf@kfs2.cua.dk> <200207021946.g62Jk9502033@aztec.santafe.edu> <200207022011.g62KBBv20071@rum.cs.yale.edu> <200207040707.g6477fG05585@aztec.santafe.edu> <200207041528.g64FSIK29686@rum.cs.yale.edu> <5xy9crb7wv.fsf@kfs2.cua.dk> <200207041846.g64Iknu30886@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1025818226 3082 127.0.0.1 (4 Jul 2002 21:30:26 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 4 Jul 2002 21:30:26 +0000 (UTC) Cc: storm@cua.dk (Kim F. Storm), Richard Stallman , kfogel@red-bean.com, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17QEBG-0000nZ-00 for ; Thu, 04 Jul 2002 23:30:26 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17QEHR-000394-00 for ; Thu, 04 Jul 2002 23:36:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17QDi8-0005Rj-00; Thu, 04 Jul 2002 17:00:20 -0400 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 17QDg1-0005Lm-00; Thu, 04 Jul 2002 16:58:09 -0400 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 2DEFF7C016; Thu, 4 Jul 2002 20:58:07 +0000 (GMT) Original-To: "Stefan Monnier" In-Reply-To: <200207041846.g64Iknu30886@rum.cs.yale.edu> Original-Lines: 43 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5493 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5493 "Stefan Monnier" writes: > > "Stefan Monnier" writes: > > > > > > I'm sure crackers will be happy about it. > > > > The argument passed to `c-add-style' allows you to buffer-locally > > > > set any variable to any value whatsoever. Hardly "safe" in my book. > > > > > > > > I didn't realize that. It will be necessary then to check > > > > the arguments to c-add-style. Still, it is better to install > > > > this checking by default than to make users install it as > > > > a customization. > > > > > > Huh? I personally don't see the point of using `c-add-style' in > > > the local variables section. My understanding is that one guy did that > > > and mentioned it here, but I have seen no evidence that anybody > > > else does. > > > It seems simpler to just set the corresponding variables one by one > > > in the local variables section. > > > > This requires that you are allowed to change the files!!! > > My point is just that since it's simpler (and doesn't require confirmation) > to set the variables one by one it's unlikely that this `c-add-tyle' > is often used in local variables sections. > > So I see no reason to provide special support for it. > (contrary to the case of `put', for example). I fully agree -- provided there is a more generic hook which can be used to accept "non-trivial" eval:s Please note that I was not advocating the solution RMS has added; I simply said that it would solve my specific problem. Now that you have pointed out that c-add-style is unsafe, I think it really doesn't make sense to try to fix that [there are zillions of other things that people might do in eval: which we cannot possible configure before-hand.] -- Kim F. Storm http://www.cua.dk