Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows]

[storm@cua.dk (Kim F. Storm)]

Juanma Barranquero <lektu@terra.es> writes:

> On Thu, 24 Oct 2002 09:13:26 +0200 (IST), Eli Zaretskii <eliz@is.elta.co.il> wrote:
> 
> > We could use some header that is common to all platforms, with a suitable 
> > ifdef if needed.
> 
> I agree, if:
> 
>  - There's a suitable .h file (I mean, not lisp.h or any non-UI oriented
>    .h file, which would be ugly).

dispextern.h seems like a good choice.  It actually uses XColor in a prototype...

I suggest adding the following near the top of the file:

  #ifdef HAVE_X_WINDOWS
  #include <X11/Xlib.h>
  #ifdef USE_X_TOOLKIT
  #include <X11/Intrinsic.h>
  #endif /* USE_X_TOOLKIT */
+ #else /* !HAVE_X_WINDOWS */
+
+ /* X-related stuff used by non-X gui code. */
+
+ typedef struct {
+   unsigned long pixel;
+   unsigned short red, green, blue;
+   char flags;
+   char pad;
+ } XColor;
+
  #endif /* HAVE_X_WINDOWS */

> 
>  - It's already (directly or indirectly) included in the relevant .c
>    files.
> 
dispextern.h is included by all files using XColor!

> But I'm *really* not arguing. If you know of such a .h file, I'm not
> opposing to do it your way if people feels is better.

Avoiding [verbatim] duplication of code or defs always make me feel better :-)

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk