From: storm@cua.dk (Kim F. Storm)
Subject: Misc. minor compile.el issues
Date: 06 Dec 2002 01:34:58 +0100 [thread overview]
Message-ID: <5xn0nkasst.fsf@kfs2.cua.dk> (raw)
The doc string for compilation-process-setup-function starts with a
`*' identifying it as a user option. Does that really make sense?
IMO, it is similar to compilation-buffer-name-function which is
not a user option.
Related to this, I would like the setup function to be able to
access the buffer and/or window for the compilation process (e.g.
to set buffer-local variables).
Currently, this can be achieved by accessing the dynamic bound
variables `outbuf' and `outwin' from the setup function, but that
seems like a gross hack.
It would make more sense to provide `outwin' as argument to the setup
function, but that would break existing code.
Alternatively, we could dynamically bind `compilation-window' and
`compilation-buffer' around the call to the setup function (and
document this "interface" in the compilation-process-setup-function
doc string).
This is still a hack, but using well-defined names.
As a final issue, I think that although the documentation for
compilation-process-setup-function says it is run just before the
process is started, it makes more sense to swap the following two
forms, to allow the setup function to control the
compilation-window-height:
(compilation-set-window-height outwin)
(if compilation-process-setup-function
(funcall compilation-process-setup-function))
In any case, I don't see any ill effects of swapping them.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next reply other threads:[~2002-12-06 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-06 0:34 Kim F. Storm [this message]
2002-12-06 16:55 ` Misc. minor compile.el issues Stefan Monnier
2002-12-06 20:15 ` Kim F. Storm
2002-12-06 20:14 ` Stefan Monnier
2002-12-07 1:49 ` Kim F. Storm
2002-12-09 15:31 ` Stefan Monnier
2002-12-07 21:26 ` Richard Stallman
2002-12-08 1:38 ` Kim F. Storm
2002-12-09 20:21 ` Richard Stallman
2002-12-10 0:51 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xn0nkasst.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).