From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: 21.3.50 for Cygwin: patch 5 Date: 09 Jan 2003 00:52:33 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xn0mb42ta.fsf@kfs2.cua.dk> References: <3E15B803.8080507@hekimian.com> <5xptrcjv3l.fsf@kfs2.cua.dk> <5xadifkudi.fsf@kfs2.cua.dk> <5x1y3pz3yd.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1042069873 9898 80.91.224.249 (8 Jan 2003 23:51:13 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 8 Jan 2003 23:51:13 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18WPya-0002ZW-00 for ; Thu, 09 Jan 2003 00:51:12 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18WQ3r-0002cp-00 for ; Thu, 09 Jan 2003 00:56:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18WPVK-0001o5-01 for emacs-devel@quimby.gnus.org; Wed, 08 Jan 2003 18:20:58 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18WPGJ-0006SE-00 for emacs-devel@gnu.org; Wed, 08 Jan 2003 18:05:27 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18WP5d-0003wy-00 for emacs-devel@gnu.org; Wed, 08 Jan 2003 17:54:28 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18WP4L-0003bA-00; Wed, 08 Jan 2003 17:53:06 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 79D977C012; Wed, 8 Jan 2003 23:53:04 +0100 (CET) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 28 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10591 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10591 Richard Stallman writes: > There are other files in > lwlib/ (e.g. xlwmenu.c) and src/ (e.g. gmalloc.c, mktime.c, > and others) which uses __P as well. > > For gmalloc.c and mktime.c, this was probably because they were copied > from Glibc, which can legitimately use names like __P. (There's one > exception: unexalpha.c.) > > In some sense we ought to change these files not to use __P when > moving the code outside Glibc, but that is unfortunate since it would > require a fork. > > However, it would be better to use P_ instead in the other files. > That is more consistent with the rest of Emacs, and with the C standard. The problem is that P_ is defined in src/lisp.h, while __P is defined in config.h (as defined by configure). I guess that's why __P is used outside src/ (and some files in src/ as well). Defining P_ in config.h (via configure) is of course possible, but even if we change everything (except the Glibc originated files) to use P_, we still will have the __P definition in config.h -- so IMO there really isn't a great need to make this change. -- Kim F. Storm http://www.cua.dk