From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: 21.3.50 for Cygwin: patch 5 Date: 10 Jan 2003 10:49:58 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xlm1t49mh.fsf@kfs2.cua.dk> References: <3E15B803.8080507@hekimian.com> <5xptrcjv3l.fsf@kfs2.cua.dk> <5xadifkudi.fsf@kfs2.cua.dk> <5x1y3pz3yd.fsf@kfs2.cua.dk> <5xn0mb42ta.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1042188810 8105 80.91.224.249 (10 Jan 2003 08:53:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 10 Jan 2003 08:53:30 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18Wuuu-00026O-00 for ; Fri, 10 Jan 2003 09:53:28 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18Wv0q-0004nl-00 for ; Fri, 10 Jan 2003 09:59:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18WuvF-0007Pv-09 for emacs-devel@quimby.gnus.org; Fri, 10 Jan 2003 03:53:49 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18WuuU-00073F-00 for emacs-devel@gnu.org; Fri, 10 Jan 2003 03:53:02 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18Wuta-0006WL-00 for emacs-devel@gnu.org; Fri, 10 Jan 2003 03:52:10 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Wus7-0004H4-00; Fri, 10 Jan 2003 03:50:35 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id 35C257C012; Fri, 10 Jan 2003 09:50:30 +0100 (CET) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 37 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10620 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10620 Richard Stallman writes: > Defining P_ in config.h (via configure) is of course possible, but > even if we change everything (except the Glibc originated files) to > use P_, we still will have the __P definition in config.h > > Why would we still have the __P definition in config.h? > Is there some reason we could not delete it, once it was not used? The Glibc files mktime.c, gmalloc.c, and strftime.c use it. mktime.c and strftime.c does declare it if it isn't defined already, but gmalloc.c doesn't. But even mktime.c and strftime.c use different ways to determine how to define __P ... Pretty messy. BTW, if I simply checkout emacs from CVS, how do I know that some files are _not_ supposed to be changed within the emacs project (such as mktime.c and regex.c)? I still think we need a "tips and tricks" section in e.g. INSTALL-CVS or admin/README (or a new file somewhere) to mention things a developer should be aware of when working on emacs source code, notably: - requirement for legal papers, - what is a "tiny change" (and how they sum up) - how to document changes (ChangeLog, NEWS, manual pages) - indentation style, use of P_ macro, which header files to use (e.g. when should a function be added to lisp.h) - how we support multiple platforms [when to duplicate code, which files contain platform specific code, etc...] but also: - quick intro to how we use texinfo -- Kim F. Storm http://www.cua.dk