From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Shall menu_bar_items and tool_bar_items look at text property keymaps? Date: 15 Feb 2002 12:39:45 +0100 Message-ID: <5xk7tfgeim.fsf@kfs2.cua.dk> References: <5x8z9yfdvz.fsf@kfs2.cua.dk> <200202140312.g1E3CIH09137@aztec.santafe.edu> <5xvgd0e8zq.fsf@kfs2.cua.dk> <200202151036.g1FAacl07300@santafe.santafe.edu> NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1013773880 523 195.204.10.66 (15 Feb 2002 11:51:20 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 15 Feb 2002 11:51:20 GMT Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16bgtb-00008L-00 for ; Fri, 15 Feb 2002 12:51:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16bghu-0007hN-00; Fri, 15 Feb 2002 06:39:14 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.33 #1 (Debian)) id 16bghN-0007bg-00 for ; Fri, 15 Feb 2002 06:38:41 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id A77277C035 for ; Fri, 15 Feb 2002 11:38:34 +0000 (GMT) Original-To: emacs-devel@gnu.org In-Reply-To: <200202151036.g1FAacl07300@santafe.santafe.edu> Original-Lines: 46 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1171 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1171 Richard Stallman writes: > Since it doesn't really work, I doubt anyone is actually using it. > > So my proposal is to remove the "look for keymaps at PT" from those > functions. > > Why change this at all? Is there a bug that needs fixing here? > If so, what is it? It is a bug: If a programmer puts a menu-bar or tool-bar binding into a keymap or local-map text property, that will not work realiable. Instead of trying to make it work (which will involve a severe performance penalty), I suggest to remove the code and document in the Elisp manual that those text property maps don't support menu-bar and tool-bar bindings. In the specific situation, I was investigating how to add a new type of keymap (details may follow later :-) when I stumbled across the (seemingly) bogus code in keyboard.c. So I decided to ask my fellow developers whether that code was really needed -- or it could be removed -- to simplify the task of adding the new type of keymap - in which case I could just remove the bogus code instead of adding more (bogus) code. > > I'm concerned because Emacs developers are putting a large fraction of > their time into areas that are attractive for programmers to work on, > but not a large fraction into areas that really help users. We need > to shift the effort to places where it will make Emacs more > powerful or more convenient or easier to learn and use. I know you regularly express this concern, and I fully agree with you! There is no need to spend time on features which are not visible to the user. However, I feel that this concern sometimes is used to reject changes to the "core" emacs that would subsequently make it *significantly* easier (for the programmer) to write packages which *does* make emacs better (for the user) in the ways you express above. And with emacs, a lisp package programmer (like me) is also a user! -- Kim F. Storm http://www.cua.dk _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel