From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Reading directory names with read-file-name Date: 24 May 2002 00:44:40 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <5xit5ev607.fsf@kfs2.cua.dk> References: <5xy9eh820e.fsf@kfs2.cua.dk> <200205182300.g4IN0Cm00753@shade.twinsun.com> <200205191940.g4JJeRw24012@aztec.santafe.edu> <5xu1p3zput.fsf@kfs2.cua.dk> <5xd6vrzlpp.fsf@kfs2.cua.dk> <200205202133.g4KLXgB25956@aztec.santafe.edu> <5xsn4iv7v6.fsf@kfs2.cua.dk> <200205232124.g4NLOQ516794@rum.cs.yale.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1022190296 12991 127.0.0.1 (23 May 2002 21:44:56 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 23 May 2002 21:44:56 +0000 (UTC) Cc: rms@gnu.org, eggert@twinsun.com, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17B0OG-0003NQ-00 for ; Thu, 23 May 2002 23:44:56 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17B0dq-0006UL-00 for ; Fri, 24 May 2002 00:01:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17B0Og-0003Vw-00; Thu, 23 May 2002 17:45:22 -0400 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 17B0NK-0003FH-00; Thu, 23 May 2002 17:43:58 -0400 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 3D4AB7C016; Thu, 23 May 2002 21:43:56 +0000 (GMT) Original-To: "Stefan Monnier" In-Reply-To: <200205232124.g4NLOQ516794@rum.cs.yale.edu> Original-Lines: 34 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:4311 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:4311 "Stefan Monnier" writes: > > My concern is that existing file-name-handlers for read-file-name > > are written to match the current API for that function, and > > they are expected to "mirror" the behaviour of read-file-name > > for any given set of arguments. > > I must say that the ange-ftp code confuses me: Me too :-) > it creates a function ange-ftp-real-read-file-name-internal > which it doesn't use. It also announces ange-ftp-read-file-name-internal > as the handler for read-file-name-internal but never defines the > function and all this while read-file-name-internal does not check > file-name-handlers (and neither does read-file-name). I'm amazed.... I've looked at that code at least 10 times over the last few days --- and I still managed to overlook this (trusting the code in ange-ftp.el). Thanks! > > So I believe that your fear is just based on some left-over, unused > and incomplete code in ange-ftp.el but is otherwise unfounded. That's good! I'll see what I can do to make this work. However, one of the candidates for an improvement could be file-name-all-completions adding a third PREDICATE arg. However, I think that's still not feasible for the reasons I mentioned in my previous mail. -- Kim F. Storm http://www.cua.dk