unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: rms@gnu.org, eggert@twinsun.com, emacs-devel@gnu.org
Subject: Re: Reading directory names with read-file-name
Date: 24 May 2002 00:44:40 +0200	[thread overview]
Message-ID: <5xit5ev607.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <200205232124.g4NLOQ516794@rum.cs.yale.edu>

"Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu> writes:

> > My concern is that existing file-name-handlers for read-file-name
> > are written to match the current API for that function, and
> > they are expected to "mirror" the behaviour of read-file-name
> > for any given set of arguments.
> 
> I must say that the ange-ftp code confuses me:

Me too :-)

> it creates a function ange-ftp-real-read-file-name-internal
> which it doesn't use.  It also announces ange-ftp-read-file-name-internal
> as the handler for read-file-name-internal but never defines the
> function and all this while read-file-name-internal does not check
> file-name-handlers (and neither does read-file-name).

I'm amazed....  I've looked at that code at least 10 times
over the last few days --- and I still managed to overlook
this (trusting the code in ange-ftp.el).  Thanks!

> 
> So I believe that your fear is just based on some left-over, unused
> and incomplete code in ange-ftp.el but is otherwise unfounded.

That's good!  I'll see what I can do to make this work.

However, one of the candidates for an improvement could be
file-name-all-completions adding a third PREDICATE arg.
However, I think that's still not feasible for the reasons
I mentioned in my previous mail.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2002-05-23 22:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-18 23:33 Reading directory names with read-file-name Kim F. Storm
2002-05-18 22:47 ` Stefan Monnier
2002-05-18 23:00 ` Paul Eggert
2002-05-19 19:40   ` Richard Stallman
2002-05-19 23:20     ` Kim F. Storm
2002-05-20  0:50       ` Kim F. Storm
2002-05-20 21:33         ` Richard Stallman
2002-05-23 22:04           ` Kim F. Storm
2002-05-23 21:24             ` Stefan Monnier
2002-05-23 22:44               ` Kim F. Storm [this message]
2002-05-24 21:14                 ` Richard Stallman
2002-05-24 21:59                   ` Stefan Monnier
2002-05-28 23:11                     ` Kim F. Storm
2002-05-24 21:14               ` Richard Stallman
2002-05-24 22:02                 ` Stefan Monnier
2002-05-20 21:33       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5xit5ev607.fsf@kfs2.cua.dk \
    --to=storm@cua.dk \
    --cc=eggert@twinsun.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).