Re: Reading directory names with read-file-name

[storm@cua.dk (Kim F. Storm)]

"Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu> writes:

> >     However, one of the candidates for an improvement could be
> >     file-name-all-completions adding a third PREDICATE arg.
> >     However, I think that's still not feasible for the reasons
> >     I mentioned in my previous mail.
> > 
> > There is no need to get that discouraged!  You have pointed out a
> > complication, but a complication does not mean it is unfeasible.  It
> > just means a little more work is needed.
> > 
> > You can fix the file name handlers--in fact, they may not even need
> > any change.  Please take a look and see if they need any change.
> 
> FWIW I don't think that file-name-all-completions and file-name-completion
> need to be changed at all in order to implement the PREDICATE argument
> for read-file-name.

No, but it makes a significant difference in performance to check for
specific predicates like file-regular-p, file-writable-p etc
in file-name-all-completions where the file is already stat'ed.

As you point out it is not _necessary_, so we can do it later
if the current functionality is inadequate for a specific purpose.

BTW, for reading directory names, I've added specific code to
handle file-directory-p efficiently.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk