From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: 21.3.50 for Cygwin: patch 5 Date: 06 Jan 2003 01:13:45 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xadifkudi.fsf@kfs2.cua.dk> References: <3E15B803.8080507@hekimian.com> <5xptrcjv3l.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1041808459 11002 80.91.224.249 (5 Jan 2003 23:14:19 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 5 Jan 2003 23:14:19 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18VJyE-0002rE-00 for ; Mon, 06 Jan 2003 00:14:18 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18VK21-0001o0-00 for ; Mon, 06 Jan 2003 00:18:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18VJye-00068M-03 for emacs-devel@quimby.gnus.org; Sun, 05 Jan 2003 18:14:44 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18VJyI-00061L-00 for emacs-devel@gnu.org; Sun, 05 Jan 2003 18:14:22 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18VJyE-0005sg-00 for emacs-devel@gnu.org; Sun, 05 Jan 2003 18:14:20 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18VJyD-0005mK-00 for emacs-devel@gnu.org; Sun, 05 Jan 2003 18:14:18 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id ACB857C012; Mon, 6 Jan 2003 00:14:14 +0100 (CET) Original-To: Benjamin Riefenstahl In-Reply-To: Original-Lines: 30 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10511 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10511 Benjamin Riefenstahl writes: > Pardon me for butting in. > > storm@cua.dk (Kim F. Storm) writes: > > We already use P_ in most cases (under src/), and __P in a few other > > cases (mostly under lib-src/ and lwlib/). > > > > So it seems a bit odd that pop.c (as the only file) uses _P. > > > > I suggest we simply change pop.c to use __P like the other files in > > lib-src. > > Both "__P" and "_P" are both firmly and totally in the compiler domain > (anything matching the regexp /^_[_A-Z]/ is). Compilers can use these > symbols however they see fit. "P_" OTOH is free for use in user > programs. So if a change is needed anyway, it should be to "P_" > (IMO). True, but the specific problem is with cygwin and the _P in pop.c; there doesn't seem to have been reported similar problems with __P, so we have two options: 1) a small, localized change in pop.c (_P => __P) 2) a wider, non-localized change (_P and __P => P_) Actually, doing 1 now doesn't mean that we cannot do 2 later... -- Kim F. Storm http://www.cua.dk