From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: silly face function names Date: 20 Dec 2002 12:28:56 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5x8yyl0w07.fsf@kfs2.cua.dk> References: <5xd6nx0xne.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1040380228 20168 80.91.224.249 (20 Dec 2002 10:30:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 20 Dec 2002 10:30:28 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18PKQC-0005F6-00 for ; Fri, 20 Dec 2002 11:30:24 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18PKRl-0006jc-00 for ; Fri, 20 Dec 2002 11:32:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18PKPV-00039J-02 for emacs-devel@quimby.gnus.org; Fri, 20 Dec 2002 05:29:41 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18PKPD-00037R-00 for emacs-devel@gnu.org; Fri, 20 Dec 2002 05:29:23 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18PKPB-00036k-00 for emacs-devel@gnu.org; Fri, 20 Dec 2002 05:29:22 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18PKPB-00035i-00; Fri, 20 Dec 2002 05:29:21 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id 824867C012; Fri, 20 Dec 2002 11:29:19 +0100 (CET) Original-To: Miles Bader In-Reply-To: Original-Lines: 32 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10302 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10302 Miles Bader writes: > storm@cua.dk (Kim F. Storm) writes: > > The names are badly chosen (having both 'set-' and '-p' is confusing), > > but if you read the names like this, it does make sense: > > > > set-face - FOO-p > > > > I would argue that 'set-' takes precedence over '-p' here... > > I'd argue that you're wrong -- `FOO-p' is not a thing which you can set. > Faces have an `inverse-video' property, and `face-inverse-video-p' is > merely the name of the predicate which tests that property. > > Having bogus function names around in emacs-proper just serves to > confuse people and cause the _next_ generation of bogus function names. Ok, but since we already have N ways to do this: (make-face-FOO face [F]) (make-face-unFOO face [F]) (set-face-attribute face F :FOO bool) (set-face-FOO-p face bool [F]) So I really don't see _any_ reason to add an N+1'th way to do the same: (set-face-FOO face bool [F]) Instead, I'd suggest simply to mark the set-face-FOO-p obsolete, and change the few existing uses of those functions to use one of the other alternatives above. -- Kim F. Storm http://www.cua.dk