From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: recent emacs font problems? Date: 30 May 2003 02:47:20 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5x8yspuup3.fsf@kfs2.cua.dk> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1054248699 22289 80.91.224.249 (29 May 2003 22:51:39 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 29 May 2003 22:51:39 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri May 30 00:51:35 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19LWFD-0005nI-00 for ; Fri, 30 May 2003 00:51:35 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19LWU4-0003QY-00 for ; Fri, 30 May 2003 01:06:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19LWFg-00028C-Ja for emacs-devel@quimby.gnus.org; Thu, 29 May 2003 18:52:04 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19LWDN-0000pj-7L for emacs-devel@gnu.org; Thu, 29 May 2003 18:49:41 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19LWCx-0008Tv-Qh for emacs-devel@gnu.org; Thu, 29 May 2003 18:49:17 -0400 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19LWCt-0008BE-V1; Thu, 29 May 2003 18:49:12 -0400 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id D294A7C012; Fri, 30 May 2003 00:49:03 +0200 (CEST) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 56 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-cc: John Paul Wallington X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14439 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14439 Reading through the case and the comments, and comparing this to the code, I'm uncertain whether the intention of the fix is to _only_ avoid overriding the :family property (that's not what the fix does, but what the comment below says), or whether the intention really is to avoid overriding any of the properties (as the fix does). If the intention is only to avoid overriding :family, then we could pass -1 for FORCE_P and test explicitly for force_p > 0 in set_lface_from_font_name in connection with the :family property. Richard Stallman writes: > Is this the right fix (not properly tested) ? > > --- /build/emacs/src/xfaces.c.~1.277.~ Wed May 28 06:00:50 2003 > +++ /build/emacs/src/xfaces.c Wed May 28 06:10:40 2003 > @@ -6584,9 +6584,7 @@ > frame_font = Fassq (Qfont, f->param_alist); > xassert (CONSP (frame_font) && STRINGP (XCDR (frame_font))); > frame_font = XCDR (frame_font); > - /* Specify 0 for FORCE_P here, so that we don't override > - a :family attribute specified for `default' for new frames. */ > - set_lface_from_font_name (f, lface, frame_font, 0, 1); > + set_lface_from_font_name (f, lface, frame_font, 1, 1); > } > #endif /* HAVE_WINDOW_SYSTEM */ > > That is not correct. It would bring back a bug I fixed recently. I > think it was the following bug. > > > Date: Thu, 15 May 2003 09:59:01 +0200 (CEST) > From: Klaus Straubinger > To: bug-gnu-emacs@gnu.org > > If the font family of the default face is changed with > (set-face-attribute 'default nil :family "fixed") > then this does not change the face's font for subsequent frames, as can > be seen with the evaluation of (face-font 'default) in the first frame > and in a second, created with C-x 5 2, respectively. > > I found that that call to set_lface_from_font_name was > clobbering the family that had come from the new-frame default. > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://mail.gnu.org/mailman/listinfo/emacs-devel > > -- Kim F. Storm http://www.cua.dk