From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: mode-line-inactive and toggle-input-method Date: 27 Feb 2002 00:15:05 +0100 Message-ID: <5x7koz96o6.fsf@kfs2.cua.dk> References: <1438-Sat16Feb2002104635+0200-eliz@is.elta.co.il> <200202171648.g1HGmup10311@aztec.santafe.edu> NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1014765548 32297 195.204.10.66 (26 Feb 2002 23:19:08 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 26 Feb 2002 23:19:08 GMT Cc: eliz@is.elta.co.il, emacs-devel@gnu.org Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16fqsF-0008Op-00 for ; Wed, 27 Feb 2002 00:19:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16fqoa-0005jm-00; Tue, 26 Feb 2002 18:15:20 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.33 #1 (Debian)) id 16fqnK-0005eu-00; Tue, 26 Feb 2002 18:14:02 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id CDDB57C035; Tue, 26 Feb 2002 23:13:59 +0000 (GMT) Original-To: rms@gnu.org In-Reply-To: <200202171648.g1HGmup10311@aztec.santafe.edu> Original-Lines: 47 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1567 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1567 Richard Stallman writes: > It seems like under some circumstances, the selected window is still > displayed with an inactive mode line. With today's CVS, try this: > > emacs -q --no-site-file > C-x 4 f FTP RET > M-% C-u C-\ latin-2-prefix RET 'i > > (The "C-u C-\" part is needed if you want to replace non-ASCII > characters: it lets you select a non-default input method.) Watch > closely: as soon as you type "C-u C-\", the mode line of the selected > window becomes displayed in the mode-line-inactive face. > > I think this is because of the way minibuffer-scroll-window is handled > in minibuf.c. Maybe it should be bound on entry to the inner > minibuffer (or to all minibuffers). See read_minibuf_unwind for how > this is handled for other things. > There are actually two problems related to the usage of the minibuffer-scroll-window variable. The first problem is that minibuffer-scroll-window is not guaranteed to keep its original value that was set (from selected-window) on entry to the minibuffer. Specifically, it is changed when a completion buffer is displayed, so that scrolling will apply to the completion window. So once a completion buffer is displayed, the original concept of the "window selected when entering minibuffer" is lost. The second problem is that if the selected window is a minibuffer, and we recursively enters the minibuffer, minibuffer-scroll-window is set to the previous minibuffer window, again losing the concept of which window was originally selected when first entering the minibuffer. I have just committed changes to fix this problem. The proper fix is to add a new internal variable (named Vminibuf_selected_window) which is similar to Vminibuf_scroll_window, but which doesn't change after entry to the minibuffer, and which doesn't change if we recursively enter the minibuffer from a selected minibuffer window. My testing shows this works very well. -- Kim F. Storm http://www.cua.dk _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel