From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Status of MAC/W32/X consolidation -- first major patch committed. Date: 17 Mar 2003 00:59:24 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5x3clmrhgj.fsf@kfs2.cua.dk> References: <5xadg38lnj.fsf@kfs2.cua.dk> <5xheaaq93k.fsf@kfs2.cua.dk> <5xbs0bq8en.fsf_-_@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1047855695 9346 80.91.224.249 (16 Mar 2003 23:01:35 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 16 Mar 2003 23:01:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 17 00:01:34 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18uh8I-0002Qb-00 for ; Mon, 17 Mar 2003 00:01:34 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18uhXf-00040S-00 for ; Mon, 17 Mar 2003 00:27:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18uh7j-0007VD-0A for emacs-devel@quimby.gnus.org; Sun, 16 Mar 2003 18:00:59 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18uh7N-0007L3-00 for emacs-devel@gnu.org; Sun, 16 Mar 2003 18:00:37 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18uh7K-00078z-00 for emacs-devel@gnu.org; Sun, 16 Mar 2003 18:00:35 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18uh7J-00072j-00; Sun, 16 Mar 2003 18:00:33 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 8A1297C012; Mon, 17 Mar 2003 00:00:30 +0100 (CET) Original-To: Jason Rumney In-Reply-To: Original-Lines: 42 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12393 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12393 Jason Rumney writes: > As part of your changes, you introduced the following function: > > static void > w32_get_glyph_overhangs (glyph, f, left, right) > struct glyph *glyph; > struct frame *f; > int *left, *right; > { > HDC hdc = get_frame_dc (f); > /* Convert to unicode! */ > x_get_glyph_overhangs (glyph, f, left, right); > release_frame_dc (f, hdc); > } > > What does the comment "Convert to unicode!" mean? Is there work > required to properly convert this to Windows? If that is the case, I > don't know when I would get time to look at it, and it will probably > get forgotten. It would be better to revert that part of the change. I didn't "invent" that comment... it was there already. The above function used to be named "x_get_glyph_overhangs" calling what used to be named "w32_get_glyph_overhangs". I swapped the names of "w32_get_glyph_overhangs" and "x_get_glyph_overhangs" to make the X and W32 code less different... > > As it is, the function is not needed. Since hdc is never used, there > is no point retrieving and releasing it. So we might as well use > x_get_glyph_overhangs directly. > I thought so myself, but it could seem like get_frame_dc had some side-effects, so I didn't want to break anything. If you think it is safe to discard w32_get_glyph_overhangs, just do it! -- Kim F. Storm http://www.cua.dk