From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master bd60ee2 1/5: auth-source: factor out parsers and add tests Date: Fri, 28 Apr 2017 12:36:40 -0400 Message-ID: <5ro9vgebfr.fsf@fencepost.gnu.org> References: <20170427213824.12196.63777@vcs0.savannah.gnu.org> <20170427213827.B6BDC22040@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493397410 29446 195.159.176.226 (28 Apr 2017 16:36:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Apr 2017 16:36:50 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 28 18:36:45 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d48su-0007Zi-RZ for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 18:36:44 +0200 Original-Received: from localhost ([::1]:37959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d48t0-0006WU-LM for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 12:36:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d48su-0006WL-2Q for emacs-devel@gnu.org; Fri, 28 Apr 2017 12:36:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d48st-0006Kj-4U for emacs-devel@gnu.org; Fri, 28 Apr 2017 12:36:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d48st-0006Kf-15 for emacs-devel@gnu.org; Fri, 28 Apr 2017 12:36:43 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d48sr-0003Dx-2u; Fri, 28 Apr 2017 12:36:41 -0400 X-Spook: Indigo Albanian Armed Revolutionary Forces Colombia X-Ran: rS2~+`'Czz@ZfWfa!\zok0}N#0U`O|gzPZ]i}d1\Ax^`4=$p^KO7>gxmU)({Av27+ST@@P X-Hue: red X-Attribution: GM In-Reply-To: (Katsumi Yamaoka's message of "Fri, 28 Apr 2017 17:10:43 +0900") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214394 Archived-At: Ted Zlatanov wrote: > What breaks, and how should I have caught this problem before it was > comitted? You could have run "make check", to see a bunch of test failures due to "return" being void. I can't resist pointing out that this was flagged by http://hydra.nixos.org/build/52055147 (BTW, your Mail-Followup-To header is broken: it only points to the list, so dropping anyone you replied to who isn't subscribed.)