[PATCH] Use %H instead of %N as our --pretty=format

[PATCH] Use %H instead of %N as our --pretty=format

[Eric Hanchrow]

%N displays "git notes", which we don't use; %H displays the commit
hash, which is much more useful.  I assume that the %N was a typo on
esr's part.

 lisp/ChangeLog  | 5 +++++
 lisp/version.el | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index dfc4ab7..893717b 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2014-08-20  Eric Hanchrow  <eric.hanchrow@gmail.com>
+
+ * version.el (emacs-repository-get-version): Use %H instead of %N
+ as our "pretty" format spec.
+
 2014-08-18  Stefan Monnier  <monnier@iro.umontreal.ca>

  * progmodes/python.el (python-shell-prompt-detect): Remove redundant
diff --git a/lisp/version.el b/lisp/version.el
index 68b502c..1ea38da 100644
--- a/lisp/version.el
+++ b/lisp/version.el
@@ -188,7 +188,7 @@ only ask the VCS if we cannot find any information
ourselves."
      (and (eq 0
       (condition-case nil
   (call-process "git" nil '(t nil) nil "log"
- "-1" "--pretty=format:%N")
+ "-1" "--pretty=format:%H")
  (error nil)))
   (not (zerop (buffer-size)))
   (replace-regexp-in-string "\n" "" (buffer-string))))))))
--
2.1.0

Re: [PATCH] Use %H instead of %N as our --pretty=format

[Glenn Morris]

Eric Hanchrow wrote:

> %N displays "git notes", which we don't use;

"We" do use it. The current git mirror contains the bzr revision as a note.
But most people don't bother to fetch the notes, I guess.
(This is written in etc/NEWS.)